Files
gbrain/test/e2e/mechanical.test.ts
Garry Tan 90c5d93fce feat: v0.18.0 — multi-source brains (one DB, many repos, federation + dotfile resolution) (#337)
* feat(v0.17.0 step 1/9): sources primitive — additive-only multi-source foundation

Lane A of the multi-repo plan. Installs the sources table and seeds a
'default' row that inherits sync.repo_path/last_commit from existing
config. This is the bisectable foundation every later step builds on;
the breaking schema changes (composite UNIQUE, files FK rewrite,
resolution_type, ingest_log.source_id) land with their paired code
rewrites in Steps 2/4/5/7 so no single commit breaks the engine.

- migration v16 (sources_table_additive) + v0_17_0 orchestrator skeleton
- sort-by-version guard in runMigrations (array insertion order can
  never cause a later migration to skip a lower one again)
- default source seeded with config '{"federated": true}' so pre-v0.17
  brains keep single-namespace search semantics after upgrade
- orchestrator phase B detects absence of file_migration_ledger and
  no-ops until Step 7 lands it
- 8 new structural tests in test/migrate.test.ts (shape, idempotency,
  scope-guard that nothing else was smuggled into v16)
- apply-migrations tests include v0.17.0 in the registered list

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 2/9): pages.source_id + composite UNIQUE (Lane B)

Migration v17 adds pages.source_id with DEFAULT 'default' and swaps the
global UNIQUE(slug) for composite UNIQUE(source_id, slug). Ships atomically
with the engine's ON CONFLICT rewrite so the constraint swap and the code
that writes under it land in the same commit — no window where the engine
sees one shape and the schema has another.

Minimum-surface engine change: only putPage's ON CONFLICT target needs
re-targeting. Other slug-based queries work unchanged because single-
source brains (the only brain shape pre-Step-5) have exactly one source
'default', so slug remains effectively unique within it. Step 5+ will
surface an explicit sourceId param on putPage for cross-source sync.

- migration v17 (pages_source_id_composite_unique) in src/core/migrate.ts
- pages.source_id + composite UNIQUE added to schema.sql + pglite-schema.ts
  for fresh installs
- ON CONFLICT (slug) → ON CONFLICT (source_id, slug) in both pglite-engine
  and postgres-engine putPage
- DEFAULT 'default' closes the Codex-flagged race where an INSERT between
  ADD COLUMN and SET NOT NULL could leave source_id NULL
- 5 new v17 structural tests (29 pass / 0 fail in migrate.test.ts)
- Full suite: 1979 pass / 3 fail (same as baseline — no regressions)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 6/9): sources CLI + source-resolver (Lane C)

Adds the CLI surface for multi-source management. Users can now register,
list, rename, federate/unfederate, and attach-to-directory a source. The
source-resolver is the shared 6-priority helper that Steps 4/5 will use
when they start surfacing an explicit --source flag on sync/extract/query.

Commands:
  gbrain sources add <id> --path <p> [--name <n>] [--federated|--no-federated]
  gbrain sources list [--json]
  gbrain sources remove <id> [--yes] [--dry-run] [--keep-storage]
  gbrain sources rename <id> <new-name>
  gbrain sources default <id>
  gbrain sources attach <id>   — writes .gbrain-source in CWD
  gbrain sources detach
  gbrain sources federate <id> / unfederate <id>

Resolution priority (source-resolver.ts) — highest first:
  1. --source flag  2. GBRAIN_SOURCE env  3. .gbrain-source dotfile walk-up
  4. longest-prefix match on registered local_path (Codex #2 fix)
  5. sources.default config  6. fallback 'default'

- add: validates id format (kebab-case alnum, 1-32), rejects overlapping
  paths (eng review §4 finding 4.1), supports federated default opt-in
- remove: guards against --yes omission + refuses to remove 'default',
  supports --dry-run, reports cascade page count
- attach/detach: matches kubectl/terraform context-pinning semantics
- Throws on overlap rather than process.exit() so the CLI error wrapper
  reports it consistently (also makes unit testing clean)

28 new tests across sources.test.ts (dispatcher + validation + overlap
guard) and source-resolver.test.ts (full 6-priority coverage including
longest-prefix). Full suite: 2012 pass / 3 fail (pre-existing PGLite
infra timeouts).

NOT in scope for Step 6 (deferred):
  - import-from-github (SSRF + clone integration)
  - prune (retention/TTL, lands v0.18)
  - MCP tool-defs regen for source-scoping on read ops (Step 5)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(v0.17.0 step 8/9): getting-started guide + migration skill + citation rule

Step 8 (Lane F) documents what Steps 1+2+6 have shipped and sets up
the agent-facing rules for multi-source.

New files:
- skills/migrations/v0.17.0.md — migration skill read by host agents
  after `gbrain apply-migrations`. Covers the v16+v17 chain, what's
  in v0.17.0 vs what lands later (v0.17.1 ACL, v0.18 sessions), and
  the new sources CLI surface. Cites docs/guides/multi-source-brains.md
  as the recipe.
- docs/guides/multi-source-brains.md — getting-started for end users.
  Three canonical scenarios (unified wiki+gstack / purpose-separated
  yc-media+garrys-list / mixed), full resolution priority, federation
  flag semantics, command reference, and citation format.

skills/brain-ops/SKILL.md — new "Cross-source citation format"
section mandating `[source-id:slug]` when the brain has multiple
sources. Matches the contract the /plan-devex-review DX review
pinned down (DX Finding 5: surface source_id in every page payload
+ citation contract). Key must be sources.id (immutable), never
sources.name.

No behavior change — this is pure documentation for what already
exists in the binary. 144 skills conformance tests still pass.

NOT in this commit (deferred to later steps):
- docs/guides/repo-architecture.md rewrite (lands with the full
  v0.17.0 PR description + release notes)
- skills/_brain-filing-rules.md "which source to file into"
  guidance (lands with Step 5 when sync surfaces --source)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 5/9): sync --source <id> routes through sources table (Lane D)

Adds the --source flag to `gbrain sync`. When set, sync reads local_path
+ last_commit from the matching sources(id) row instead of the global
sync.repo_path / sync.last_commit config keys, and writes last_commit +
last_sync_at back to the same row. Backward compat: --source omitted =
pre-v0.17 behavior exactly, global config path unchanged.

- SyncOpts.sourceId threaded through performSync + performFullSync
- readSyncAnchor/writeSyncAnchor helpers centralize the sources-vs-config
  branch so every read/write goes through one decision point. Makes
  Step 5's later per-source sync-failures tracking a one-file change.
- --source resolved via src/core/source-resolver.ts (Step 6), so any
  command that shell-exposes resolveSourceId gets env var + dotfile
  walk-up + longest-prefix for free.
- Error message for missing source local_path is actionable:
    Source "gstack" has no local_path. Run: gbrain sources add gstack --path <path>
- last_sync_at auto-updates on every last_commit advance so `gbrain
  sources list` shows real recency.

No regression: 2012 pass / 3 fail (same as baseline).

NOT in this commit (deferred per plan):
- Per-source failure tracking (~/.gbrain/sources/<id>/sync-failures.jsonl)
- runImport source-awareness (import.ts path — Step 5 continuation)
- Partial-success semantics when walking N sources — single-source flow
  today, multi-walk lands when the top-level `gbrain sync` without
  --source starts iterating all sources.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 4/9): qualified [[source:slug]] + links.resolution_type (Lane B)

Adds source-pinned wikilink syntax and records the resolution kind on
each edge so `gbrain extract --refresh-unqualified` (future) can
re-resolve bare references when the source topology changes.

Wikilink syntax extension:
  [[concepts/ai]]             — unqualified; resolves via local-first fallback
  [[wiki:concepts/ai]]        — qualified; target pinned to sources.id='wiki'
  [[gstack:projects/foo|Display]]  — qualified + display name

The qualified regex runs first and masks matched spans so the
unqualified pass can't double-emit. Source id format enforced to match
the sources CLI validation: [a-z0-9](?:[a-z0-9-]{0,30}[a-z0-9])?

Schema:
- migration v18 adds links.resolution_type TEXT with CHECK constraint
  ('qualified'|'unqualified' or NULL for legacy/manual/frontmatter edges)
- schema.sql + pglite-schema.ts updated for fresh installs

EntityRef type:
- sourceId is OPTIONAL (only set on qualified wikilinks). Markdown
  [Name](path) and unqualified wikilinks omit it so strict toEqual
  tests pre-v0.17 keep working (69 existing tests still pass).

Tests:
- 5 new qualified-wikilink extraction tests + 1 migration v18 structural
  assertion. 75 tests in test/link-extraction.test.ts (up from 69).
- Full suite: 2018 pass / 3 fail (pre-existing PGLite infra timeouts).

NOT in this commit (deferred to Step 3 / Step 5 continuation):
- Writing resolution_type to the DB (addLink / addLinksBatch don't
  carry the field yet — that's the plumb-through that lands with
  Step 3 when search/dedup also needs source-aware result keys).
- `gbrain extract --refresh-unqualified` re-resolver.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 3/9): source-aware search dedup composite keys (Lane B)

Search dedup now keys on (source_id, slug) instead of slug alone. Pre-
v0.17 would collapse two same-slug pages in different sources into
one, destroying cross-source recall. Codex outside-voice review flagged
this as regression-critical — this commit ships the fix plus tests
that lock the invariant in.

Dedup pipeline (src/core/search/dedup.ts):
- pageKey(r) helper — one canonical composite-key derivation. Falls
  back to source_id='default' for pre-v0.17 rows so single-source
  brains behave identically to before.
- Layer 1 (dedupBySource): group-by composite key.
- Layer 4 (capPerPage): count-by composite key.
- guaranteeCompiledTruth: swap scoped to matching (source_id, slug),
  so wiki:topics/ai can't accidentally pull gstack:topics/ai's
  compiled_truth chunk.

SearchResult type gains optional source_id — populated by SQL JOINs
in both engines, falls through as 'default' for legacy callers.

Engine SQL:
- pglite-engine.ts + postgres-engine.ts: search SELECTs add p.source_id
- rowToSearchResult (utils.ts): maps row.source_id → result.source_id
  when present. Shape stays backward compatible (field optional).

Tests — 4 new in test/dedup.test.ts:
- same-slug-different-source does NOT collapse (the critical regression
  guard Codex called out)
- same-slug-same-source DOES still collapse (no over-correction)
- missing source_id falls back to 'default' for pre-v0.17 compat
- compiled_truth guarantee scopes to composite key (Codex second pass
  caught this specific path would leak otherwise)

Full suite: 2022 pass / 3 fail (3 pre-existing PGLite infra timeouts).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(v0.17.0 step 7/9): file_migration_ledger + phase-B storage backfill (Lane E)

Adds files.source_id + files.page_id + the file_migration_ledger
state machine that drives storage object rewrites. Each per-file
transition is its own transaction so crash-point recovery is a
ledger read, not a filesystem inspection. Codex second-pass review
flagged that "skip if already has source prefix" was an unsafe
heuristic — the ledger replaces it with explicit state tracking.

Schema:
- migration v19 (files_source_id_page_id_ledger): handler-only
  (PGLite has no files table; Postgres-only gate). ADDs
  source_id + page_id to files, backfills page_id from page_slug
  scoped to source_id='default', creates file_migration_ledger
  with PK on file_id (Codex: not storage_path_old — two sources
  can share an old path during migration).
- schema.sql updated for fresh Postgres installs; file_migration_ledger
  gets RLS alongside other tables.

Runtime:
- src/commands/migrations/v0_17_0-storage-backfill.ts: drives the
  ledger state machine pending → copy_done → db_updated → complete.
  Idempotent per row: re-running resumes from whichever state
  crashed. Old objects preserved (no delete) so operators can
  verify the soak window before a future cleanup release.
- phase B in v0_17_0.ts orchestrator: wires the storage backend
  (Supabase/S3/local) through createStorage, runs runStorageBackfill,
  reports per-state counts + first-three error details.

Tests — 13 new in test/storage-backfill.test.ts:
- pending → copy_done → db_updated → complete happy path
- 3 crash-point recovery tests (resume from copy_done, resume from
  db_updated, failed rows don't auto-retry)
- already-complete rows are skipped with zero side effects
- idempotent re-upload (exists-check skips redundant upload)
- dry-run mode (no storage, reports counts without mutating)

Plus 5 new migrate.test.ts assertions for v19 structure (handler-
only, PGLite gate, source_id + page_id + ledger DDL, default-source
backfill scope, state machine values).

Full suite: 2035 pass / 3 fail (3 pre-existing PGLite infra
timeouts).

NOT in this commit (explicitly deferred):
- DROP old page_slug column — kept for backward compat until
  operators have time to verify page_id everywhere.
- DROP old UNIQUE(storage_path) in favor of UNIQUE(source_id,
  storage_path) — same reason, deferred to later cleanup.
- Actual cleanup phase that deletes old objects post-soak.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(v0.17.0 step 9/9): full multi-source PGLite integration suite (Lane G)

End-to-end exercise of every v0.17.0 surface against real PGLite
(in-memory, fast — no DATABASE_URL needed). The migration chain
v2→v19 runs start-to-finish and the test asserts each Step's
invariants hold together.

16 new integration tests across 7 describes:

1. Migration-installed state:
   - sources('default') exists with federated=true config
   - pages.source_id column has DEFAULT 'default'
   - composite UNIQUE (source_id, slug) is installed

2. Default-source write path:
   - putPage without explicit source → source_id='default' via schema
     default clause (no engine API change needed for single-source brains)

3. Composite UNIQUE regression guards (Codex-flagged):
   - Same slug in two different sources coexists
   - Third insert with same (source_id, slug) hits the UNIQUE constraint

4. sources CLI round-trip:
   - federate / unfederate flips config.federated
   - rename changes display, id stays immutable

5. Source resolution priority (integration):
   - Explicit flag > env var > fallback to default
   - Unregistered explicit source errors with actionable message

6. Cascade semantics:
   - sources remove cascades to pages; default source untouched

7. links.resolution_type (Step 4):
   - Qualified/unqualified values accepted
   - CHECK constraint rejects invalid values

All 16 tests pass. Full suite: 2042 pass / 4 fail (4 pre-existing
PGLite beforeEach timeouts in test/wait-for-completion,
test/extract-fs, test/e2e/search-quality, test/e2e/graph-quality
— count fluctuated 3-5 on baseline from variance alone).

Total new tests across Steps 1-9: ~85 unit + integration tests
(sources, source-resolver, migrate v16/v17/v18/v19 structural,
link-extraction qualified wikilinks, dedup regression-critical,
storage-backfill state machine + crash recovery, full
multi-source PGLite integration).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump to v0.18.0 + CHANGELOG entry (multi-source brains)

One-viewport release summary + itemized changes covering all 9 steps
of the multi-source primitive. Notes the v0.17 → v0.18 version bump
rationale (master shipped gbrain dream as v0.17 while this branch was
in flight).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ci): v0_18_0 orchestrator TS narrow + mechanical test ON CONFLICT

Two CI failures on PR #337:

1. tsc TS2367 at src/commands/migrations/v0_18_0.ts:190 —
   after the early-return on `a.status === 'failed'` (line 179),
   TypeScript narrows `a.status` to `'skipped' | 'complete'`, so the
   subsequent `a.status === 'failed' ? 'failed' :` branch was dead
   code and refused to compile. Dropped the redundant check.

2. E2E `file_list LIMIT enforcement` at test/e2e/mechanical.test.ts:636 —
   the test pre-seeded a pages row with `ON CONFLICT (slug) DO NOTHING`
   but v21 swapped the global UNIQUE for `UNIQUE (source_id, slug)`, so
   Postgres rejects with "no unique or exclusion constraint matching".
   Updated the conflict target to the composite key.

Tier-1 E2E had only this one failing test; everything else passed.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(e2e): v0.18.0 multi-source against real Postgres (v20-v23 schema + cascade + sync)

Closes the three biggest confidence gaps the author flagged in the
self-audit of PR #337:

1. No real Postgres E2E — PGLite has no files table, so v23's
   files.source_id + files.page_id rewrite + file_migration_ledger
   seed was NEVER executed against the real DB. This file covers it.

2. `gbrain sync --source <id>` had zero direct tests. Now has two:
   one that asserts performSync({sourceId}) reads local_path from the
   sources row (not the global config), one that asserts no-sourceId
   falls back to the global sync.repo_path.

3. Cascade delete coverage — previously verified only pages count
   after source removal. Now verifies pages + content_chunks +
   timeline_entries + links + files ALL cascade-delete when a source
   is removed.

6 describes, 16 tests total:

- Schema shape (fresh install): 6 tests confirming sources('default'),
  pages.source_id NOT NULL with DEFAULT, composite UNIQUE pages
  (source_id, slug) replaces global UNIQUE(slug), links.resolution_type
  column + CHECK, files.source_id + page_id columns, file_migration_ledger
  table + status CHECK.

- Composite UNIQUE semantics: 3 tests confirming same-slug in two
  sources coexists (Codex-critical regression guard), duplicate
  (source_id, slug) hits the UNIQUE, putPage targets default source
  by schema DEFAULT.

- Cascade delete: 1 test building a fully populated source (2 pages,
  chunks, timeline, links, files) then removing it + asserting every
  dependent row is gone.

- Sync routing: 2 tests confirming performSync({sourceId}) reads
  per-source local_path vs global config.

- Sources surface: 3 tests for federate/unfederate flipping + rename
  preserving id.

- Storage backfill: 1 end-to-end test seeding ledger + running
  runStorageBackfill against a stub StorageBackend, asserting
  pending → complete transition and files.storage_path rewrite.

Gated by DATABASE_URL per CLAUDE.md E2E lifecycle. Each describe's
beforeAll defensively DELETEs non-default sources + file_migration_ledger
rows so reruns are hermetic (sources isn't in helpers.ALL_TABLES).

Verified: 16/16 pass on first run AND second run (residual-state fix
holds). Full E2E suite still green.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(ci): TS2352 in multi-source E2E — cast postgres.js RowList via unknown

tsc rejects the direct
  `(rows as { column_name: string }[]).map(...)`
cast because postgres.js RowList rows have an iterable-row shape that
doesn't overlap with the plain-object target. Standard fix: cast via
`unknown` first so the narrowing is explicit.

Verified: `bunx tsc --noEmit` clean (ignoring the pre-existing baseUrl
deprecation warning).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(v0.18.0): addLinksBatch + addTimelineEntriesBatch source-aware JOINs

Batch APIs JOINed on pages.slug globally, so two pages sharing the same
slug across sources would silently fan out — addLinksBatch(['a->b']) in
a brain with 'a' in both 'default' and 'alt' wrote 2 edges instead of 1.
Same bug on addTimelineEntriesBatch.

Fix:
- LinkBatchInput + TimelineBatchInput gain optional source_id fields
  (from_source_id, to_source_id, origin_source_id for links; source_id
  for timeline). All default to 'default' so existing callers are
  backward-compatible on single-source brains.
- pglite-engine + postgres-engine batch JOINs now composite-key on
  (slug, source_id). Postgres adds 3 more unnest arrays for links + 1
  for timeline — still one bind per column, no 65535-param cap risk.
- LEFT JOIN for origin pages also source-qualified so frontmatter-
  provenance edges don't cross-pollinate across sources.

Regression coverage:
- test/pglite-engine.test.ts: 5 new tests covering default-path isolation,
  explicit alt-source writes, and cross-source edges.
- test/e2e/multi-source.test.ts: 4 new tests against real Postgres so
  postgres-js's unnest() bind path is exercised (structurally different
  from PGLite's).

Gap #4 from the PR self-audit — latent bug, not previously reachable
because every existing caller wrote to the default source only.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-22 16:24:23 -07:00

1172 lines
48 KiB
TypeScript

/**
* E2E Mechanical Tests — Tier 1 (no API keys required)
*
* Tests all operations against a real Postgres+pgvector database.
* Requires DATABASE_URL env var or .env.testing file.
*
* Run: DATABASE_URL=... bun test test/e2e/mechanical.test.ts
*/
import { describe, test, expect, beforeAll, afterAll } from 'bun:test';
import { readFileSync, writeFileSync, mkdtempSync, rmSync } from 'fs';
import { join } from 'path';
import { execSync } from 'child_process';
import { tmpdir } from 'os';
import {
hasDatabase, setupDB, teardownDB, getEngine, getConn,
importFixtures, importFixture, time, dumpDBState, FIXTURES_PATH,
} from './helpers.ts';
import { operationsByName, operations } from '../../src/core/operations.ts';
import type { OperationContext } from '../../src/core/operations.ts';
import { importFromContent } from '../../src/core/import-file.ts';
// Skip all E2E tests if no database is configured
const skip = !hasDatabase();
const describeE2E = skip ? describe.skip : describe;
function makeCtx(opts: { remote?: boolean } = {}): OperationContext {
return {
engine: getEngine(),
config: { engine: 'postgres', database_url: process.env.DATABASE_URL! },
logger: { info: () => {}, warn: () => {}, error: () => {} },
dryRun: false,
// Default: trusted local invocation (matches `gbrain call` semantics).
remote: opts.remote ?? false,
};
}
async function callOp(name: string, params: Record<string, unknown> = {}) {
const op = operationsByName[name];
if (!op) throw new Error(`Unknown operation: ${name}`);
return op.handler(makeCtx(), params);
}
// ─────────────────────────────────────────────────────────────────
// Page CRUD
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Page CRUD', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('fixture import creates correct page count', async () => {
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(16);
});
test('get_page returns correct data for person', async () => {
const page = await callOp('get_page', { slug: 'people/sarah-chen' }) as any;
expect(page.title).toBe('Sarah Chen');
expect(page.type).toBe('person');
expect(page.compiled_truth).toContain('NovaMind');
expect(page.tags).toContain('founder');
expect(page.tags).toContain('yc-w25');
});
test('get_page returns correct data for concept', async () => {
const page = await callOp('get_page', { slug: 'concepts/retrieval-augmented-generation' }) as any;
expect(page.title).toBe('Retrieval-Augmented Generation');
expect(page.type).toBe('concept');
expect(page.compiled_truth).toContain('検索拡張生成');
});
test('get_page for company includes key details', async () => {
const page = await callOp('get_page', { slug: 'companies/novamind' }) as any;
expect(page.type).toBe('company');
expect(page.compiled_truth).toContain('Sarah Chen');
});
test('list_pages type filter returns correct count', async () => {
const people = await callOp('list_pages', { type: 'person' }) as any[];
expect(people.length).toBe(3);
const companies = await callOp('list_pages', { type: 'company' }) as any[];
expect(companies.length).toBe(3); // novamind, threshold-ventures, ohmygreen
const concepts = await callOp('list_pages', { type: 'concept' }) as any[];
expect(concepts.length).toBe(5); // compiled-truth, hybrid-search, RAG, notes-march-2024, big-file
});
test('list_pages tag filter works', async () => {
const ycPages = await callOp('list_pages', { tag: 'yc-w25' }) as any[];
expect(ycPages.length).toBeGreaterThanOrEqual(2);
expect(ycPages.some((p: any) => p.slug === 'people/sarah-chen')).toBe(true);
});
test('put_page updates existing page', async () => {
const updated = readFileSync(join(FIXTURES_PATH, 'people/sarah-chen.md'), 'utf-8')
.replace('Stanford CS', 'MIT CS');
// Use importFromContent directly with noEmbed to avoid OpenAI timeout
const engine = getEngine();
const result = await importFromContent(engine, 'people/sarah-chen', updated, { noEmbed: true });
expect(result.status).toBe('imported');
const page = await callOp('get_page', { slug: 'people/sarah-chen' }) as any;
expect(page.compiled_truth).toContain('MIT CS');
});
test('delete_page removes page and others survive', async () => {
await callOp('delete_page', { slug: 'sources/crustdata-sarah-chen' });
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(15);
// Other pages still exist
const sarah = await callOp('get_page', { slug: 'people/sarah-chen' }) as any;
expect(sarah.title).toBe('Sarah Chen');
});
});
// ─────────────────────────────────────────────────────────────────
// Search
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Search', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('keyword search for "NovaMind" returns multiple hits', async () => {
const results = await callOp('search', { query: 'NovaMind' }) as any[];
expect(results.length).toBeGreaterThanOrEqual(3);
const slugs = results.map((r: any) => r.slug);
expect(slugs).toContain('companies/novamind');
});
test('keyword search for "Threshold Ventures" finds investor', async () => {
const results = await callOp('search', { query: 'Threshold Ventures' }) as any[];
expect(results.length).toBeGreaterThanOrEqual(1);
const slugs = results.map((r: any) => r.slug);
expect(slugs).toContain('companies/threshold-ventures');
});
test('keyword search for "Stanford" finds Priya', async () => {
const results = await callOp('search', { query: 'Stanford' }) as any[];
expect(results.length).toBeGreaterThanOrEqual(1);
const slugs = results.map((r: any) => r.slug);
expect(slugs).toContain('people/priya-patel');
});
test('keyword search for nonexistent term returns empty', async () => {
const results = await callOp('search', { query: 'xyznonexistent123' }) as any[];
expect(results.length).toBe(0);
});
test('search quality: precision@5 for known queries', async () => {
const groundTruth: Record<string, string[]> = {
'NovaMind': ['people/sarah-chen', 'companies/novamind', 'deals/novamind-seed'],
'hybrid search': ['concepts/hybrid-search', 'concepts/retrieval-augmented-generation'],
'compiled truth': ['concepts/compiled-truth'],
};
const scores: Record<string, number> = {};
for (const [query, expected] of Object.entries(groundTruth)) {
const results = await callOp('search', { query, limit: 5 }) as any[];
const topSlugs = results.slice(0, 5).map((r: any) => r.slug);
const hits = expected.filter(e => topSlugs.includes(e));
scores[query] = hits.length / Math.min(expected.length, 5);
}
console.log('\n Search Quality (precision@5, keyword-only):');
for (const [query, score] of Object.entries(scores)) {
console.log(` "${query}": ${(score * 100).toFixed(0)}%`);
}
});
});
// ─────────────────────────────────────────────────────────────────
// Links
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Links', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('add_link + get_links + get_backlinks round trip', async () => {
await callOp('add_link', {
from: 'people/sarah-chen',
to: 'companies/novamind',
link_type: 'founded',
context: 'CEO and founder since 2024',
});
const links = await callOp('get_links', { slug: 'people/sarah-chen' }) as any[];
expect(links.some((l: any) => l.to_slug === 'companies/novamind' || l.to_page_slug === 'companies/novamind')).toBe(true);
const backlinks = await callOp('get_backlinks', { slug: 'companies/novamind' }) as any[];
expect(backlinks.some((l: any) => l.from_slug === 'people/sarah-chen' || l.from_page_slug === 'people/sarah-chen')).toBe(true);
});
test('traverse_graph finds connected pages', async () => {
// Links should already be added from prior test in this describe block
const graph = await callOp('traverse_graph', { slug: 'people/sarah-chen', depth: 2 }) as any;
expect(Array.isArray(graph)).toBe(true);
expect(graph.length).toBeGreaterThanOrEqual(1);
});
test('remove_link removes the link', async () => {
await callOp('add_link', { from: 'people/marcus-reid', to: 'companies/threshold-ventures' });
await callOp('remove_link', { from: 'people/marcus-reid', to: 'companies/threshold-ventures' });
const links = await callOp('get_links', { slug: 'people/marcus-reid' }) as any[];
const hasLink = links.some((l: any) =>
(l.to_slug || l.to_page_slug) === 'companies/threshold-ventures'
);
expect(hasLink).toBe(false);
});
});
// ─────────────────────────────────────────────────────────────────
// Tags
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Tags', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('get_tags returns imported tags', async () => {
const tags = await callOp('get_tags', { slug: 'people/sarah-chen' }) as string[];
expect(tags).toContain('founder');
expect(tags).toContain('yc-w25');
expect(tags).toContain('ai-agents');
});
test('add_tag + remove_tag round trip', async () => {
await callOp('add_tag', { slug: 'people/marcus-reid', tag: 'test-tag' });
let tags = await callOp('get_tags', { slug: 'people/marcus-reid' }) as string[];
expect(tags).toContain('test-tag');
await callOp('remove_tag', { slug: 'people/marcus-reid', tag: 'test-tag' });
tags = await callOp('get_tags', { slug: 'people/marcus-reid' }) as string[];
expect(tags).not.toContain('test-tag');
});
test('list_pages with tag filter finds tagged pages', async () => {
await callOp('add_tag', { slug: 'people/priya-patel', tag: 'test-search-tag' });
const pages = await callOp('list_pages', { tag: 'test-search-tag' }) as any[];
expect(pages.length).toBe(1);
expect(pages[0].slug).toBe('people/priya-patel');
});
});
// ─────────────────────────────────────────────────────────────────
// Timeline
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Timeline', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('add_timeline_entry + get_timeline round trip', async () => {
await callOp('add_timeline_entry', {
slug: 'people/sarah-chen',
date: '2025-04-01',
summary: 'Test timeline entry',
detail: 'Added via E2E test',
source: 'e2e-test',
});
const timeline = await callOp('get_timeline', { slug: 'people/sarah-chen' }) as any[];
expect(timeline.length).toBeGreaterThanOrEqual(1);
const entry = timeline.find((e: any) => e.summary === 'Test timeline entry');
expect(entry).toBeDefined();
});
});
// ─────────────────────────────────────────────────────────────────
// Batch methods (addLinksBatch / addTimelineEntriesBatch)
// ─────────────────────────────────────────────────────────────────
//
// Postgres-engine batch methods use postgres-js's sql(rows, 'col1', ...) helper,
// which is structurally different from PGLite's manual $N placeholder construction
// (covered in test/pglite-engine.test.ts). These tests verify the postgres-js code
// path against a real Postgres against the same invariants.
describeE2E('E2E: addLinksBatch (postgres-engine)', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('empty batch returns 0 with no DB call', async () => {
const engine = getEngine();
expect(await engine.addLinksBatch([])).toBe(0);
});
test('within-batch duplicates dedup via ON CONFLICT (no 21000 cardinality error)', async () => {
const engine = getEngine();
const conn = getConn();
// Deterministic cleanup so re-runs aren't perturbed by prior fixture state.
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-dup'`;
const inserted = await engine.addLinksBatch([
{ from_slug: 'people/sarah-chen', to_slug: 'companies/novamind', link_type: 'e2e-batch-dup' },
{ from_slug: 'people/sarah-chen', to_slug: 'companies/novamind', link_type: 'e2e-batch-dup' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-dup'`;
});
test('rows with missing slug silently dropped by JOIN', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-missing'`;
const inserted = await engine.addLinksBatch([
{ from_slug: 'people/does-not-exist', to_slug: 'companies/novamind', link_type: 'e2e-batch-missing' },
{ from_slug: 'people/sarah-chen', to_slug: 'companies/novamind', link_type: 'e2e-batch-missing' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-missing'`;
});
test('half-existing batch returns count of new only', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-half'`;
await engine.addLink('people/sarah-chen', 'companies/novamind', 'pre-existing', 'e2e-batch-half');
const inserted = await engine.addLinksBatch([
{ from_slug: 'people/sarah-chen', to_slug: 'companies/novamind', link_type: 'e2e-batch-half' },
{ from_slug: 'people/sarah-chen', to_slug: 'people/marcus-reid', link_type: 'e2e-batch-half' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM links WHERE link_type = 'e2e-batch-half'`;
});
test('missing optional fields normalize to empty strings (NOT NULL safety)', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM links WHERE link_type = ''`;
// No link_type, no context — must default to '' to satisfy NOT NULL.
const inserted = await engine.addLinksBatch([
{ from_slug: 'people/sarah-chen', to_slug: 'companies/novamind' },
]);
expect(inserted).toBe(1);
const rows = await conn`
SELECT link_type, context FROM links
WHERE from_page_id = (SELECT id FROM pages WHERE slug = 'people/sarah-chen')
AND to_page_id = (SELECT id FROM pages WHERE slug = 'companies/novamind')
AND link_type = ''
`;
expect(rows.length).toBe(1);
expect(rows[0].context).toBe('');
await conn`DELETE FROM links WHERE link_type = ''`;
});
});
describeE2E('E2E: addTimelineEntriesBatch (postgres-engine)', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('empty batch returns 0', async () => {
const engine = getEngine();
expect(await engine.addTimelineEntriesBatch([])).toBe(0);
});
test('within-batch duplicates dedup via ON CONFLICT', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM timeline_entries WHERE summary = 'e2e-batch-tl-dup'`;
const inserted = await engine.addTimelineEntriesBatch([
{ slug: 'people/sarah-chen', date: '2025-05-01', summary: 'e2e-batch-tl-dup' },
{ slug: 'people/sarah-chen', date: '2025-05-01', summary: 'e2e-batch-tl-dup' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM timeline_entries WHERE summary = 'e2e-batch-tl-dup'`;
});
test('rows with missing slug silently dropped by JOIN', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM timeline_entries WHERE summary = 'e2e-batch-tl-missing'`;
const inserted = await engine.addTimelineEntriesBatch([
{ slug: 'people/no-such-page', date: '2025-05-02', summary: 'e2e-batch-tl-missing' },
{ slug: 'people/sarah-chen', date: '2025-05-02', summary: 'e2e-batch-tl-missing' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM timeline_entries WHERE summary = 'e2e-batch-tl-missing'`;
});
test('mix of new + existing returns count of new only', async () => {
const engine = getEngine();
const conn = getConn();
await conn`DELETE FROM timeline_entries WHERE summary IN ('e2e-batch-tl-half-1', 'e2e-batch-tl-half-2')`;
await engine.addTimelineEntry('people/sarah-chen', { date: '2025-05-03', summary: 'e2e-batch-tl-half-1' });
const inserted = await engine.addTimelineEntriesBatch([
{ slug: 'people/sarah-chen', date: '2025-05-03', summary: 'e2e-batch-tl-half-1' },
{ slug: 'people/sarah-chen', date: '2025-05-04', summary: 'e2e-batch-tl-half-2' },
]);
expect(inserted).toBe(1);
await conn`DELETE FROM timeline_entries WHERE summary IN ('e2e-batch-tl-half-1', 'e2e-batch-tl-half-2')`;
});
});
// ─────────────────────────────────────────────────────────────────
// Versions
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Versions', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('put_page creates version, revert restores', async () => {
const original = await callOp('get_page', { slug: 'people/sarah-chen' }) as any;
// Modify page using importFromContent with noEmbed
const modified = readFileSync(join(FIXTURES_PATH, 'people/sarah-chen.md'), 'utf-8')
.replace('Sarah Chen', 'Sarah Chen (Modified)');
const engine = getEngine();
await importFromContent(engine, 'people/sarah-chen', modified, { noEmbed: true });
// Check versions exist
const versions = await callOp('get_versions', { slug: 'people/sarah-chen' }) as any[];
expect(versions.length).toBeGreaterThanOrEqual(1);
// Revert to first version
const firstVersion = versions[versions.length - 1];
await callOp('revert_version', { slug: 'people/sarah-chen', version_id: firstVersion.id });
const reverted = await callOp('get_page', { slug: 'people/sarah-chen' }) as any;
expect(reverted.compiled_truth).not.toContain('(Modified)');
});
});
// ─────────────────────────────────────────────────────────────────
// Admin
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Admin', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('get_stats returns valid structure', async () => {
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(16);
expect(typeof stats.chunk_count).toBe('number');
});
test('get_health returns valid structure', async () => {
const health = await callOp('get_health') as any;
expect(health).toBeDefined();
expect(typeof health.page_count).toBe('number');
expect(typeof health.embed_coverage).toBe('number');
});
});
// ─────────────────────────────────────────────────────────────────
// Chunks & Resolution
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Chunks & Resolution', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('get_chunks returns chunks for imported page', async () => {
const chunks = await callOp('get_chunks', { slug: 'people/sarah-chen' }) as any[];
expect(chunks.length).toBeGreaterThan(0);
expect(chunks[0].chunk_text).toBeTruthy();
});
test('resolve_slugs finds partial match', async () => {
const matches = await callOp('resolve_slugs', { partial: 'sarah' }) as string[];
expect(matches).toContain('people/sarah-chen');
});
test('resolve_slugs finds exact match', async () => {
const matches = await callOp('resolve_slugs', { partial: 'people/sarah-chen' }) as string[];
expect(matches).toContain('people/sarah-chen');
});
});
// ─────────────────────────────────────────────────────────────────
// Ingest Log & Raw Data
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Ingest Log & Raw Data', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('log_ingest + get_ingest_log round trip', async () => {
await callOp('log_ingest', {
source_type: 'e2e-test',
source_ref: 'test-run-1',
pages_updated: ['people/sarah-chen', 'companies/novamind'],
summary: 'E2E test ingest',
});
const log = await callOp('get_ingest_log', { limit: 5 }) as any[];
expect(log.length).toBeGreaterThanOrEqual(1);
const entry = log.find((e: any) => e.source_ref === 'test-run-1');
expect(entry).toBeDefined();
expect(entry.source_type).toBe('e2e-test');
});
test('put_raw_data + get_raw_data round trip', async () => {
const testData = { education: 'Stanford CS 2020', title: 'CEO' };
await callOp('put_raw_data', {
slug: 'people/sarah-chen',
source: 'crustdata',
data: testData,
});
const raw = await callOp('get_raw_data', {
slug: 'people/sarah-chen',
source: 'crustdata',
}) as any[];
expect(raw.length).toBeGreaterThanOrEqual(1);
// JSONB may come back as string or parsed object
const data = typeof raw[0].data === 'string' ? JSON.parse(raw[0].data) : raw[0].data;
expect(data.education).toBe('Stanford CS 2020');
expect(data.title).toBe('CEO');
});
});
// ─────────────────────────────────────────────────────────────────
// Files (stub verification)
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Files', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('file_list returns empty initially', async () => {
const files = await callOp('file_list', {}) as any[];
expect(files.length).toBe(0);
});
test('file_upload stores metadata + file_list shows it', async () => {
// Create a temp file
const tmpDir = mkdtempSync(join(tmpdir(), 'gbrain-e2e-'));
const tmpFile = join(tmpDir, 'test-doc.pdf');
writeFileSync(tmpFile, 'fake pdf content');
try {
const result = await callOp('file_upload', {
path: tmpFile,
page_slug: 'people/sarah-chen',
}) as any;
expect(result.status).toBe('uploaded');
expect(result.storage_path).toContain('sarah-chen');
// Verify file_list
const files = await callOp('file_list', {}) as any[];
expect(files.length).toBe(1);
// Verify file_url returns URI format
const url = await callOp('file_url', { storage_path: result.storage_path }) as any;
expect(url.url).toContain('gbrain:files/');
} finally {
rmSync(tmpDir, { recursive: true });
}
});
// Security-wave-3 regression: MCP/remote callers MUST be confined to cwd
// (Issue #139). Local CLI callers are unrestricted — different trust model.
test('file_upload rejects outside-cwd paths for remote (MCP) callers', async () => {
const tmpDir = mkdtempSync(join(tmpdir(), 'gbrain-e2e-ssrf-'));
const tmpFile = join(tmpDir, 'stealable.txt');
writeFileSync(tmpFile, 'sensitive');
try {
const op = operationsByName['file_upload'];
let threw = false;
try {
await op.handler(makeCtx({ remote: true }), {
path: tmpFile,
page_slug: 'people/sarah-chen',
});
} catch (e: any) {
threw = true;
expect(String(e.message || e)).toMatch(/within the working directory/i);
}
expect(threw).toBe(true);
} finally {
rmSync(tmpDir, { recursive: true });
}
});
});
// ─────────────────────────────────────────────────────────────────
// Security: Query Bounds
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: file_list LIMIT enforcement', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('file_list with slug filter respects LIMIT 100', async () => {
const sql = getConn();
const testSlug = 'test-limit-slug';
// Create the parent page first (FK constraint on files.page_slug)
await sql`
INSERT INTO pages (slug, title, type, compiled_truth, frontmatter)
VALUES (${testSlug}, ${'Test Limit Page'}, ${'note'}, ${'body'}, ${'{}'}::jsonb)
ON CONFLICT (source_id, slug) DO NOTHING
`;
// Insert 150 file rows for the same slug
for (let i = 0; i < 150; i++) {
await sql`
INSERT INTO files (page_slug, filename, storage_path, mime_type, size_bytes, content_hash, metadata)
VALUES (${testSlug}, ${'file-' + String(i).padStart(3, '0') + '.txt'}, ${testSlug + '/file-' + i + '.txt'}, ${'text/plain'}, ${100}, ${'hash-' + i}, ${'{}'}::jsonb)
ON CONFLICT (storage_path) DO NOTHING
`;
}
// Verify we inserted 150
const count = await sql`SELECT count(*) as cnt FROM files WHERE page_slug = ${testSlug}`;
expect(Number(count[0].cnt)).toBe(150);
// Call file_list with slug — should return at most 100
const files = await callOp('file_list', { slug: testSlug }) as any[];
expect(files.length).toBeLessThanOrEqual(100);
expect(files.length).toBe(100);
});
test('file_list without slug also respects LIMIT 100', async () => {
// The 150 rows from the previous test are still in the DB
const files = await callOp('file_list', {}) as any[];
expect(files.length).toBeLessThanOrEqual(100);
});
});
// ─────────────────────────────────────────────────────────────────
// Idempotency Stress
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Idempotency', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('double import produces no duplicates', async () => {
// First import
await importFixtures();
const stats1 = await callOp('get_stats') as any;
// Second import (identical content)
await importFixtures();
const stats2 = await callOp('get_stats') as any;
expect(stats2.page_count).toBe(stats1.page_count);
expect(stats2.chunk_count).toBe(stats1.chunk_count);
});
test('modify one fixture, reimport, only that page updates', async () => {
await importFixtures();
const engine = getEngine();
// Modify sarah-chen content
const modified = readFileSync(join(FIXTURES_PATH, 'people/sarah-chen.md'), 'utf-8')
.replace('Stanford CS', 'MIT CS');
const result = await importFromContent(engine, 'people/sarah-chen', modified, { noEmbed: true });
expect(result.status).toBe('imported');
// Other pages should have been skipped if reimported
const content = readFileSync(join(FIXTURES_PATH, 'people/marcus-reid.md'), 'utf-8');
const { parseMarkdown } = await import('../../src/core/markdown.ts');
const parsed = parseMarkdown(content, 'people/marcus-reid.md');
const result2 = await importFromContent(engine, parsed.slug, content, { noEmbed: true });
expect(result2.status).toBe('skipped');
});
});
// ─────────────────────────────────────────────────────────────────
// Setup Journey (CLI subprocess tests)
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Setup Journey', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
const cliCwd = join(import.meta.dir, '../..');
const cliEnv = () => ({ ...process.env, DATABASE_URL: process.env.DATABASE_URL! });
test('gbrain init --non-interactive connects and initializes', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'init', '--non-interactive', '--url', process.env.DATABASE_URL!],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
const stdout = new TextDecoder().decode(result.stdout);
expect(result.exitCode).toBe(0);
expect(stdout).toContain('Brain ready');
}, 30_000);
test('gbrain import imports fixtures via CLI', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'import', '--no-embed', FIXTURES_PATH],
cwd: cliCwd,
env: cliEnv(),
timeout: 30_000,
});
const stdout = new TextDecoder().decode(result.stdout);
expect(result.exitCode).toBe(0);
expect(stdout).toContain('imported');
}, 60_000);
test('gbrain search returns results via CLI', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'search', 'NovaMind'],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
const stdout = new TextDecoder().decode(result.stdout);
expect(result.exitCode).toBe(0);
expect(stdout.length).toBeGreaterThan(0);
}, 30_000);
test('gbrain stats shows page count via CLI', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'stats'],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
expect(result.exitCode).toBe(0);
}, 30_000);
test('gbrain health runs via CLI', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'health'],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
expect(result.exitCode).toBe(0);
}, 30_000);
});
// ─────────────────────────────────────────────────────────────────
// Init Edge Cases
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Init Edge Cases', () => {
afterAll(teardownDB);
test('init --non-interactive without URL fails gracefully', () => {
const env = { ...process.env };
delete env.DATABASE_URL;
delete env.GBRAIN_DATABASE_URL;
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'init', '--non-interactive'],
cwd: join(import.meta.dir, '../..'),
env,
timeout: 10_000,
});
expect(result.exitCode).not.toBe(0);
});
test('double init is idempotent', async () => {
await setupDB();
const conn = getConn();
const before = await conn.unsafe(`SELECT count(*) as n FROM information_schema.tables WHERE table_schema = 'public'`);
// Re-init
const { initSchema } = await import('../../src/core/db.ts');
await initSchema();
const after = await conn.unsafe(`SELECT count(*) as n FROM information_schema.tables WHERE table_schema = 'public'`);
expect(after[0].n).toBe(before[0].n);
});
test('init then import then re-init preserves pages', async () => {
await setupDB();
await importFixtures();
const before = await callOp('get_stats') as any;
const { initSchema } = await import('../../src/core/db.ts');
await initSchema();
const after = await callOp('get_stats') as any;
expect(after.page_count).toBe(before.page_count);
});
});
// ─────────────────────────────────────────────────────────────────
// Schema Idempotency
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Schema Idempotency', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('initSchema twice produces no errors and same object count', async () => {
const conn = getConn();
const tables1 = await conn.unsafe(`SELECT count(*) as n FROM information_schema.tables WHERE table_schema = 'public'`);
const indexes1 = await conn.unsafe(`SELECT count(*) as n FROM pg_indexes WHERE schemaname = 'public'`);
const { initSchema } = await import('../../src/core/db.ts');
await initSchema();
const tables2 = await conn.unsafe(`SELECT count(*) as n FROM information_schema.tables WHERE table_schema = 'public'`);
const indexes2 = await conn.unsafe(`SELECT count(*) as n FROM pg_indexes WHERE schemaname = 'public'`);
expect(tables2[0].n).toBe(tables1[0].n);
expect(indexes2[0].n).toBe(indexes1[0].n);
});
});
// ─────────────────────────────────────────────────────────────────
// Schema Diff Guard
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Schema Diff Guard', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('all expected tables exist', async () => {
const conn = getConn();
const tables = await conn.unsafe(`
SELECT table_name FROM information_schema.tables
WHERE table_schema = 'public' AND table_type = 'BASE TABLE'
ORDER BY table_name
`);
const tableNames = tables.map((t: any) => t.table_name);
const expected = [
'config', 'content_chunks', 'files', 'ingest_log',
'links', 'page_versions', 'pages', 'raw_data',
'tags', 'timeline_entries',
];
for (const table of expected) {
expect(tableNames).toContain(table);
}
});
test('pgvector extension is installed', async () => {
const conn = getConn();
const ext = await conn.unsafe(`SELECT extname FROM pg_extension WHERE extname = 'vector'`);
expect(ext.length).toBe(1);
});
test('pg_trgm extension is installed', async () => {
const conn = getConn();
const ext = await conn.unsafe(`SELECT extname FROM pg_extension WHERE extname = 'pg_trgm'`);
expect(ext.length).toBe(1);
});
});
// ─────────────────────────────────────────────────────────────────
// Slug with Special Characters (Apple Notes fix)
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Slug with Special Characters', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
test('imports files with spaces in filename', async () => {
const page = await callOp('get_page', { slug: 'apple-notes/2017-05-03-ohmygreen' }) as any;
expect(page).not.toBeNull();
expect(page.title).toBe('OhMyGreen');
expect(page.type).toBe('company');
});
test('imports files with parens in filename', async () => {
const page = await callOp('get_page', { slug: 'apple-notes/notes-march-2024' }) as any;
expect(page).not.toBeNull();
expect(page.title).toBe('March 2024 Notes');
});
test('search finds content from special-char files', async () => {
const results = await callOp('search', { query: 'OhMyGreen' }) as any[];
expect(results.length).toBeGreaterThanOrEqual(1);
const slugs = results.map((r: any) => r.slug);
expect(slugs).toContain('apple-notes/2017-05-03-ohmygreen');
});
test('re-import of special-char files is idempotent', async () => {
const before = await callOp('get_stats') as any;
await importFixtures(); // second import
const after = await callOp('get_stats') as any;
expect(after.page_count).toBe(before.page_count);
});
});
// ─────────────────────────────────────────────────────────────────
// RLS Verification
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: RLS Verification', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('RLS is enabled on all gbrain tables', async () => {
const conn = getConn();
const tables = await conn.unsafe(`
SELECT tablename, rowsecurity FROM pg_tables
WHERE schemaname = 'public'
AND tablename IN ('pages','content_chunks','links','tags','raw_data',
'page_versions','timeline_entries','ingest_log','config','files')
`);
const noRls = tables.filter((t: any) => !t.rowsecurity);
// Some test DBs may not have BYPASSRLS privilege, so RLS might be skipped.
// If RLS was enabled, all tables should have it.
if (tables.some((t: any) => t.rowsecurity)) {
expect(noRls.length).toBe(0);
}
});
test('current user role has BYPASSRLS', async () => {
const conn = getConn();
const rows = await conn.unsafe(`SELECT rolbypassrls FROM pg_roles WHERE rolname = current_user`);
// Docker test DB uses postgres role which has BYPASSRLS
if (rows.length > 0) {
expect(rows[0].rolbypassrls).toBe(true);
}
});
});
// ─────────────────────────────────────────────────────────────────
// Doctor Command
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Doctor Command', () => {
beforeAll(async () => {
await setupDB();
await importFixtures();
});
afterAll(teardownDB);
const cliCwd = join(import.meta.dir, '../..');
const cliEnv = () => ({ ...process.env, DATABASE_URL: process.env.DATABASE_URL!, GBRAIN_DATABASE_URL: process.env.DATABASE_URL! });
test('gbrain doctor exits 0 on healthy DB', () => {
// Init first so config exists for CLI
Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'init', '--non-interactive', '--url', process.env.DATABASE_URL!],
cwd: cliCwd, env: cliEnv(), timeout: 15_000,
});
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'doctor'],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
expect(result.exitCode).toBe(0);
}, 60_000);
test('gbrain doctor --json produces valid JSON', () => {
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'doctor', '--json'],
cwd: cliCwd,
env: cliEnv(),
timeout: 15_000,
});
const stdout = new TextDecoder().decode(result.stdout);
const parsed = JSON.parse(stdout);
expect(parsed.status).toBeDefined();
expect(Array.isArray(parsed.checks)).toBe(true);
expect(parsed.checks.length).toBeGreaterThan(0);
for (const check of parsed.checks) {
expect(['ok', 'warn', 'fail']).toContain(check.status);
expect(typeof check.name).toBe('string');
expect(typeof check.message).toBe('string');
}
}, 30_000);
});
// ─────────────────────────────────────────────────────────────────
// Parallel Import
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Parallel Import', () => {
afterAll(teardownDB);
const cliCwd = join(import.meta.dir, '../..');
const cliEnv = () => ({ ...process.env, DATABASE_URL: process.env.DATABASE_URL!, GBRAIN_DATABASE_URL: process.env.DATABASE_URL! });
function initCli() {
Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'init', '--non-interactive', '--url', process.env.DATABASE_URL!],
cwd: cliCwd, env: cliEnv(), timeout: 15_000,
});
}
// Store sequential baseline for comparison
let seqPageCount: number;
let seqChunkCount: number;
let seqPageSlugs: string[];
test('sequential baseline: import all fixtures', async () => {
await setupDB();
initCli();
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'import', '--no-embed', FIXTURES_PATH],
cwd: cliCwd,
env: cliEnv(),
timeout: 30_000,
});
expect(result.exitCode).toBe(0);
const stats = await callOp('get_stats') as any;
seqPageCount = stats.page_count;
seqChunkCount = stats.chunk_count;
const pages = await callOp('list_pages', { limit: 200 }) as any[];
seqPageSlugs = pages.map((p: any) => p.slug).sort();
expect(seqPageCount).toBeGreaterThan(0);
expect(seqChunkCount).toBeGreaterThan(0);
}, 60_000);
test('parallel import with --workers 2 matches sequential page count', async () => {
await setupDB();
initCli();
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'import', '--no-embed', '--workers', '2', FIXTURES_PATH],
cwd: cliCwd,
env: cliEnv(),
timeout: 30_000,
});
expect(result.exitCode).toBe(0);
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(seqPageCount);
}, 60_000);
test('parallel import has same chunk count (no duplicates)', async () => {
const stats = await callOp('get_stats') as any;
expect(stats.chunk_count).toBe(seqChunkCount);
});
test('parallel import has same page slugs', async () => {
const pages = await callOp('list_pages', { limit: 200 }) as any[];
const parSlugs = pages.map((p: any) => p.slug).sort();
expect(parSlugs).toEqual(seqPageSlugs);
});
test('no duplicate pages from concurrent writes', async () => {
const conn = getConn();
const dupes = await conn.unsafe(`
SELECT slug, count(*) as n FROM pages GROUP BY slug HAVING count(*) > 1
`);
expect(dupes.length).toBe(0);
});
test('no duplicate chunks from concurrent writes', async () => {
const conn = getConn();
const dupes = await conn.unsafe(`
SELECT page_id, chunk_index, count(*) as n
FROM content_chunks
GROUP BY page_id, chunk_index
HAVING count(*) > 1
`);
expect(dupes.length).toBe(0);
});
test('parallel import with --workers 4 also works', async () => {
await setupDB();
initCli();
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'import', '--no-embed', '--workers', '4', FIXTURES_PATH],
cwd: cliCwd,
env: cliEnv(),
timeout: 30_000,
});
expect(result.exitCode).toBe(0);
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(seqPageCount);
expect(stats.chunk_count).toBe(seqChunkCount);
}, 60_000);
test('re-import with workers is idempotent', async () => {
// Import again on top of existing data
const result = Bun.spawnSync({
cmd: ['bun', 'run', 'src/cli.ts', 'import', '--no-embed', '--workers', '2', FIXTURES_PATH],
cwd: cliCwd,
env: cliEnv(),
timeout: 30_000,
});
expect(result.exitCode).toBe(0);
const stats = await callOp('get_stats') as any;
expect(stats.page_count).toBe(seqPageCount);
expect(stats.chunk_count).toBe(seqChunkCount);
}, 60_000);
});
// ─────────────────────────────────────────────────────────────────
// Performance Baselines
// ─────────────────────────────────────────────────────────────────
describeE2E('E2E: Performance Baselines', () => {
beforeAll(async () => {
await setupDB();
});
afterAll(teardownDB);
test('import + search + link performance', async () => {
const [_, importMs] = await time(importFixtures);
const searchTimes: number[] = [];
for (const q of ['NovaMind', 'hybrid search', 'Stanford', 'investor', 'compiled truth']) {
const [__, ms] = await time(() => callOp('search', { query: q }));
searchTimes.push(ms);
}
const [___, linkMs] = await time(async () => {
await callOp('add_link', { from: 'people/sarah-chen', to: 'companies/novamind' });
await callOp('get_backlinks', { slug: 'companies/novamind' });
});
searchTimes.sort((a, b) => a - b);
const p50 = searchTimes[Math.floor(searchTimes.length * 0.5)];
const p99 = searchTimes[searchTimes.length - 1];
console.log('\n Performance Baselines:');
console.log(` Import 13 fixtures: ${importMs.toFixed(0)}ms`);
console.log(` Search p50: ${p50.toFixed(0)}ms`);
console.log(` Search p99: ${p99.toFixed(0)}ms`);
console.log(` Link + backlink: ${linkMs.toFixed(0)}ms`);
});
});