Files
gbrain/test/migrations-v0_14_0.test.ts
Garry Tan b5fa3d044a fix: 8 root-cause fixes from /investigate (v0.14.2) (#259)
* fix: 8 root-cause fixes from /investigate wave

Consolidated bundle of bug fixes from /investigate on the 8 deferred bugs.
Each fix was designed to go at the structural gap, not the symptom. Codex
verified 20 load-bearing claims on the plan; 12 triggered plan revisions.

Bug 2  — GBRAIN_POOL_SIZE env knob + init finally blocks (no auto-detect).
         Covers both the singleton pool (db.ts) and instance pool (import.ts:140).
Bug 3  — Centralize migration ledger writes in apply-migrations runner.
         Removed appendCompletedMigration from v0_11_0, v0_12_0, v0_12_2,
         v0_13_0, v0_13_1. Added 3-partial wedge cap + --force-retry reset.
         'complete wins' preserved; no partial can regress a completed migration.
Bug 5  — v0.14.0 migration registered. src/commands/migrations/v0_14_0.ts
         ships Phase A (ALTER minion_jobs.max_stalled SET DEFAULT 3) + Phase B
         (pending-host-work ping for shell-jobs adoption).
Bug 6/10 — jsonb_agg(DISTINCT ...) in legacy traverseGraph (both engines).
         Presentation-level dedup; schema still preserves provenance rows.
Bug 7  — doctor --fast reads DB URL source via getDbUrlSource() in config.ts.
         Precise message: 'Skipping DB checks (--fast mode, URL present from env)'
         replaces the misleading 'No database configured'.
Bug 8  — max_stalled default bumped 1→3 in schema-embedded.ts, pglite-schema.ts,
         schema.sql (new installs). v0_14_0 Phase A ALTER for existing installs.
         autopilot-cycle handler yields to event loop between phases so the
         worker's lock-renewal timer fires on huge brains. (Deep AbortSignal
         threading through runEmbedCore/runExtractCore/runBacklinksCore/performSync
         deferred to v0.15 queue polish.)
Bug 9  — Gate sync.last_commit on no-failures across all three sync paths
         (incremental, full via runImport, gbrain import git continuity).
         recordSyncFailures() helper + ~/.gbrain/sync-failures.jsonl with
         dedup key path+commit+error-hash. New flags: --skip-failed (ack) +
         --retry-failed (re-attempt). Doctor surfaces unacknowledged failures.
Bug 11 — brain_score breakdown fields on BrainHealth (embed_coverage_score,
         link_density_score, timeline_coverage_score, no_orphans_score,
         no_dead_links_score); sum equals brain_score by construction.
         dead_links now on the type (resolves featuresTeaserForDoctor drift).
         orphan_pages kept as 'islanded' (no inbound AND no outbound) and
         docs updated to match — explicit semantic instead of doc drift.

New tests: test/traverse-graph-dedup.test.ts, test/sync-failures.test.ts,
test/brain-score-breakdown.test.ts, test/migration-resume.test.ts,
test/migrations-v0_14_0.test.ts. Extended: migrate, doctor, apply-migrations.

All 1696 unit tests pass locally. postgres-jsonb E2E regression unchanged
(none of these touch the JSONB write surface).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

* docs: v0.14.2 CHANGELOG + CLAUDE.md; align migration-flow E2E with runner-owned ledger

CHANGELOG: v0.14.2 entry in the standard release-summary format
(two-line headline + lead + numbers table + "what this means" +
"To take advantage of v0.14.2" self-repair block + itemized
changes grouped by reliability / observability / graph correctness /
new migration / tests / deferred-to-v0.15).

CLAUDE.md: new "Key commands added in v0.14.2" section covers
--skip-failed, --retry-failed, --force-retry, GBRAIN_POOL_SIZE env,
and the new doctor checks (sync_failures, brain_score breakdown).
Migration orchestrator docs updated to describe v0_14_0.ts + the
runner-owned ledger contract from Bug 3.

test/e2e/migration-flow.test.ts: three assertions updated to match
the Bug 3 contract — orchestrators no longer append to completed.jsonl
directly, so direct-orchestrator E2E calls leave the ledger empty.
Preferences assertions remain (that's still the orchestrator's side
of the contract). Runner's ledger write is covered by the unit suite
(test/apply-migrations.test.ts + test/migration-resume.test.ts).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
2026-04-20 23:14:38 +08:00

104 lines
4.3 KiB
TypeScript

/**
* Bug 5 + Bug 8 — v0_14_0 orchestrator regression.
*
* The migration ships:
* - Phase A (schema): ALTER minion_jobs.max_stalled SET DEFAULT 3
* - Phase B (host-work): append skill-ping entry to
* ~/.gbrain/migrations/pending-host-work.jsonl
*
* Both phases are idempotent — re-running the migration is a no-op after
* the first successful pass.
*/
import { describe, test, expect, beforeEach, afterEach } from 'bun:test';
import { mkdtempSync, rmSync, readFileSync, existsSync } from 'fs';
import { join } from 'path';
import { tmpdir } from 'os';
let tmpHome: string;
const originalHome = process.env.HOME;
beforeEach(() => {
tmpHome = mkdtempSync(join(tmpdir(), 'gbrain-v0_14_0-'));
process.env.HOME = tmpHome;
});
afterEach(() => {
if (originalHome) process.env.HOME = originalHome;
else delete process.env.HOME;
try { rmSync(tmpHome, { recursive: true, force: true }); } catch { /* ignore */ }
});
describe('Bug 5 + Bug 8 — v0_14_0 module shape', () => {
test('v0_14_0 is registered in migrations/index.ts', async () => {
const { migrations } = await import('../src/commands/migrations/index.ts');
const m = migrations.find(x => x.version === '0.14.0');
expect(m).toBeDefined();
expect(m!.featurePitch.headline).toBeTruthy();
});
test('v0_14_0 does NOT write the ledger directly', async () => {
const source = await Bun.file(new URL('../src/commands/migrations/v0_14_0.ts', import.meta.url)).text();
expect(source).not.toContain('appendCompletedMigration');
});
test('orchestrator returns complete when phase A is skipped (no config)', async () => {
const { v0_14_0 } = await import('../src/commands/migrations/v0_14_0.ts');
// No loadConfig() backing → phaseASchema reports skipped (no brain).
// Phase B still emits the host-work ping.
const result = await v0_14_0.orchestrator({
yes: true,
dryRun: false,
noAutopilotInstall: true,
});
expect(['complete', 'partial']).toContain(result.status);
expect(result.version).toBe('0.14.0');
const hostWork = result.phases.find(p => p.name === 'host-work');
expect(hostWork).toBeDefined();
});
});
describe('Bug 5 — Phase B host-work entry dedup', () => {
test('first run writes the entry, second run is a skip', async () => {
const { v0_14_0 } = await import('../src/commands/migrations/v0_14_0.ts');
const first = await v0_14_0.orchestrator({ yes: true, dryRun: false, noAutopilotInstall: true });
const hostPath = join(tmpHome, '.gbrain', 'migrations', 'pending-host-work.jsonl');
expect(existsSync(hostPath)).toBe(true);
const beforeLines = readFileSync(hostPath, 'utf-8').split('\n').filter(l => l.trim()).length;
expect(beforeLines).toBe(1);
// Second run — Phase B should skip, not duplicate.
await v0_14_0.orchestrator({ yes: true, dryRun: false, noAutopilotInstall: true });
const afterLines = readFileSync(hostPath, 'utf-8').split('\n').filter(l => l.trim()).length;
expect(afterLines).toBe(1);
const entry = JSON.parse(readFileSync(hostPath, 'utf-8').split('\n')[0]);
expect(entry.migration).toBe('0.14.0');
expect(entry.skill).toBe('skills/migrations/v0.14.0.md');
});
test('dry-run writes nothing', async () => {
const { v0_14_0 } = await import('../src/commands/migrations/v0_14_0.ts');
await v0_14_0.orchestrator({ yes: true, dryRun: true, noAutopilotInstall: true });
const hostPath = join(tmpHome, '.gbrain', 'migrations', 'pending-host-work.jsonl');
expect(existsSync(hostPath)).toBe(false);
});
});
describe('Bug 8 — max_stalled default bumped in schema files', () => {
test('schema-embedded.ts has max_stalled DEFAULT 3', async () => {
const source = await Bun.file(new URL('../src/core/schema-embedded.ts', import.meta.url)).text();
expect(source).toContain('max_stalled INTEGER NOT NULL DEFAULT 3');
});
test('pglite-schema.ts has max_stalled DEFAULT 3', async () => {
const source = await Bun.file(new URL('../src/core/pglite-schema.ts', import.meta.url)).text();
expect(source).toContain('max_stalled INTEGER NOT NULL DEFAULT 3');
});
test('schema.sql has max_stalled DEFAULT 3', async () => {
const source = await Bun.file(new URL('../src/schema.sql', import.meta.url)).text();
expect(source).toContain('max_stalled INTEGER NOT NULL DEFAULT 3');
});
});