Files
gbrain/test/wait-for-completion.test.ts
Garry Tan 96178d726e fix(subagent): v0.16.3 — bind Anthropic SDK correctly + enable tsc in CI (#318)
* fix(subagent): bind Anthropic SDK messages.create() correctly

The makeSubagentHandler was casting `new Anthropic()` directly to
MessagesClient, but MessagesClient.create() maps to sdk.messages.create(),
not sdk.create(). Every subagent job immediately died with:

  client.create is not a function

Fix: wrap the SDK instance so .create() delegates to .messages.create()
with proper `this` binding via .bind(sdk.messages).

Discovered on first production run of gbrain agent against Supabase.

Co-Authored-By: Wintermute <wintermute@openclaw.ai>

* chore(ci): add typescript typecheck to test pipeline + clean up baseline errors

Root cause infra gap that let the v0.16.0 subagent bug ship: CI ran
only `bun test`, which transpiles types without checking them. Type
errors only surfaced at runtime, in production.

Changes:
- Add `typescript` devDep and a `typecheck` npm script (`tsc --noEmit`).
- Chain `bun run typecheck` into `bun run test` so developers get the
  same pipeline locally that CI runs.
- Flip `.github/workflows/test.yml` to invoke `bun run test` (the npm
  script, including typecheck) instead of `bun test` (runner only).
- Clean up 100+ pre-existing type errors across 30+ files so the first
  run of `tsc --noEmit` is green. Root causes were:
  - `databaseUrl` → `database_url` rename drift in test fixtures (9 files)
  - `PageType` union missing `'meeting'` / `'note'` entries that are
    already used in both src and tests (link-extraction.ts comments
    acknowledged the gap)
  - `GBrainConfig.storage` field never declared despite being read in
    files.ts and operations.ts
  - `ErrorCode` union missing `'permission_denied'`
  - `OrchestratorOpts` shape changed; test callers not updated
  - Dead-code comparisons in migration orchestrators against narrowed
    status types
  - postgres.js `Row`-callback type drift on several `.map()` calls
  - Buffer-as-BodyInit assignment in supabase.ts (real but non-fatal
    runtime bug; Uint8Array slice works and is type-correct)
  - Various `as X` single-step casts that now need `as unknown as X`
    per TS's stricter structural-conversion rules
- Bump `beforeAll` hook timeout to 30s on four PGLite-heavy tests that
  were flaky under parallel test execution: wait-for-completion,
  extract-fs, e2e/search-quality, e2e/graph-quality. All pass in
  isolation; timeouts only happened when dozens of PGLite instances
  init'd simultaneously.

The new CI pipeline now fails on any type error across src/ or test/,
giving us the compile-time regression guard the subagent fix depends on.

* fix(subagent): bind Anthropic SDK messages.create() correctly

Shipped bug: v0.16.0 cast `new Anthropic()` to `MessagesClient`, but
`.create()` lives at `sdk.messages.create`, not on the top-level client.
Every subagent job in production died on first LLM call with
`client.create is not a function`. Discovered on the first `gbrain agent
run` against Supabase.

Fix: assign `sdk.messages` directly to the `MessagesClient` slot.
`sdk.messages` IS the object with a callable `.create()`; the original
bug was picking the wrong entry point on the SDK. No helper, no
wrapper, no `.bind()` — JS method-call semantics preserve `this` at
the call site because `subagent.ts:336` invokes `client.create(...)`
with `client === sdk.messages`.

The one-line assignment also typechecks cleanly against the existing
`MessagesClient` interface (SDK's first `create` overload:
`(MessageCreateParamsNonStreaming, Core.RequestOptions?) =>
APIPromise<Message>` is assignable structurally). This gives us
compile-time regression protection: anyone reverting to
`new Anthropic()` would fail tsc because `Anthropic` has no top-level
`.create`. (The companion chore commit puts `tsc --noEmit` in CI so
this guard is enforced.)

Also adds a `makeAnthropic?: () => Anthropic` dep-injection seam so
the factory default construction branch is testable without real API
calls. Regression test drives one handler turn through a fake SDK,
asserting `sdk.messages.create` is actually called. If someone later
reverts to `new Anthropic()`, both guards fire: tsc fails AND the test
fails.

Co-Authored-By: Wintermute <wintermute@garrytan.com>

* chore(tests): add bunfig.toml + 60s hook timeouts to stabilize PGLite-heavy suites

After turning on tsc in CI (previous commit), running the full `bun run test`
suite in one shot triggered flaky `beforeEach/afterEach hook timed out`
failures on 8+ test files. Every failure traced to PGLite WASM init
contention when many test files spin up fresh PGLite instances in parallel;
each one alone passes in isolation.

- `bunfig.toml` sets the global test hook timeout to 60s (default is 5s),
  covering every test file without per-file edits.
- Individual `beforeAll(fn, 60_000)` / `beforeEach(fn, 15_000)` calls on
  the 8 tests that flaked most stay in place as explicit safety nets so
  a future bunfig config change doesn't silently re-introduce the flake.

Result: 1997 pass, 0 fail on `bun run test` (117 tests added since the
prior baseline by picking up typecheck-gated passes). No infrastructure
flake tolerated in CI.

* chore: bump version and changelog (v0.16.3)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Wintermute <wintermute@garrytan.com>
Co-authored-by: Wintermute <wintermute@openclaw.ai>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-04-22 01:34:22 -07:00

113 lines
3.9 KiB
TypeScript

/**
* waitForCompletion tests. Uses PGLite in-memory so the poll path exercises
* a real getJob over a real engine.
*/
import { describe, test, expect, beforeAll, afterAll, beforeEach } from 'bun:test';
import { PGLiteEngine } from '../src/core/pglite-engine.ts';
import { MinionQueue } from '../src/core/minions/queue.ts';
import { waitForCompletion, TimeoutError, __testing } from '../src/core/minions/wait-for-completion.ts';
let engine: PGLiteEngine;
let queue: MinionQueue;
beforeAll(async () => {
engine = new PGLiteEngine();
await engine.connect({ database_url: '' });
await engine.initSchema();
queue = new MinionQueue(engine);
}, 60_000);
afterAll(async () => {
await engine.disconnect();
});
beforeEach(async () => {
await engine.executeRaw('DELETE FROM minion_jobs');
});
describe('waitForCompletion terminal states', () => {
test('TERMINAL_STATES covers every terminal MinionJobStatus value', () => {
expect(__testing.TERMINAL_STATES).toEqual(['completed', 'failed', 'dead', 'cancelled']);
});
test('returns immediately when job already completed (fast path)', async () => {
const j = await queue.add('t', {});
const claimed = await queue.claim('tok', 30000, 'default', ['t']);
await queue.completeJob(claimed!.id, 'tok', { ok: true });
const t0 = Date.now();
const res = await waitForCompletion(queue, j.id, { pollMs: 500 });
expect(res.status).toBe('completed');
expect(Date.now() - t0).toBeLessThan(300); // no full poll cycle
});
test('returns when job transitions to failed mid-wait', async () => {
const j = await queue.add('t', {});
const p = waitForCompletion(queue, j.id, { pollMs: 25, timeoutMs: 5000 });
// Transition the job to failed after a brief delay.
setTimeout(async () => {
const claimed = await queue.claim('tok', 30000, 'default', ['t']);
await queue.failJob(claimed!.id, 'tok', 'boom', 'failed');
}, 60);
const res = await p;
expect(res.status).toBe('failed');
});
test('returns when job transitions to cancelled', async () => {
const j = await queue.add('t', {});
const p = waitForCompletion(queue, j.id, { pollMs: 25, timeoutMs: 5000 });
setTimeout(() => { queue.cancelJob(j.id); }, 60);
const res = await p;
expect(res.status).toBe('cancelled');
});
test('throws TimeoutError when job stays non-terminal past timeoutMs', async () => {
const j = await queue.add('t', {});
await expect(
waitForCompletion(queue, j.id, { pollMs: 25, timeoutMs: 100 })
).rejects.toBeInstanceOf(TimeoutError);
});
test('TimeoutError carries the jobId and elapsedMs', async () => {
const j = await queue.add('t', {});
try {
await waitForCompletion(queue, j.id, { pollMs: 25, timeoutMs: 80 });
throw new Error('should have thrown');
} catch (e) {
expect(e).toBeInstanceOf(TimeoutError);
const te = e as TimeoutError;
expect(te.jobId).toBe(j.id);
expect(te.elapsedMs).toBeGreaterThanOrEqual(80);
}
});
test('TimeoutError does NOT cancel the job', async () => {
const j = await queue.add('t', {});
try {
await waitForCompletion(queue, j.id, { pollMs: 25, timeoutMs: 80 });
} catch {}
const still = await queue.getJob(j.id);
expect(still?.status).toBe('waiting');
});
test('AbortSignal exits loop early without throwing', async () => {
const j = await queue.add('t', {});
const ac = new AbortController();
setTimeout(() => ac.abort(), 50);
const res = await waitForCompletion(queue, j.id, {
pollMs: 25,
timeoutMs: 5000,
signal: ac.signal,
});
expect(res.id).toBe(j.id);
// Still waiting — we just stopped polling.
expect(res.status).toBe('waiting');
});
test('throws when job id does not exist', async () => {
await expect(waitForCompletion(queue, 99_999, { pollMs: 10, timeoutMs: 100 }))
.rejects.toThrow(/not found/);
});
});