* feat(v0.17.0 step 1/9): sources primitive — additive-only multi-source foundation
Lane A of the multi-repo plan. Installs the sources table and seeds a
'default' row that inherits sync.repo_path/last_commit from existing
config. This is the bisectable foundation every later step builds on;
the breaking schema changes (composite UNIQUE, files FK rewrite,
resolution_type, ingest_log.source_id) land with their paired code
rewrites in Steps 2/4/5/7 so no single commit breaks the engine.
- migration v16 (sources_table_additive) + v0_17_0 orchestrator skeleton
- sort-by-version guard in runMigrations (array insertion order can
never cause a later migration to skip a lower one again)
- default source seeded with config '{"federated": true}' so pre-v0.17
brains keep single-namespace search semantics after upgrade
- orchestrator phase B detects absence of file_migration_ledger and
no-ops until Step 7 lands it
- 8 new structural tests in test/migrate.test.ts (shape, idempotency,
scope-guard that nothing else was smuggled into v16)
- apply-migrations tests include v0.17.0 in the registered list
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 2/9): pages.source_id + composite UNIQUE (Lane B)
Migration v17 adds pages.source_id with DEFAULT 'default' and swaps the
global UNIQUE(slug) for composite UNIQUE(source_id, slug). Ships atomically
with the engine's ON CONFLICT rewrite so the constraint swap and the code
that writes under it land in the same commit — no window where the engine
sees one shape and the schema has another.
Minimum-surface engine change: only putPage's ON CONFLICT target needs
re-targeting. Other slug-based queries work unchanged because single-
source brains (the only brain shape pre-Step-5) have exactly one source
'default', so slug remains effectively unique within it. Step 5+ will
surface an explicit sourceId param on putPage for cross-source sync.
- migration v17 (pages_source_id_composite_unique) in src/core/migrate.ts
- pages.source_id + composite UNIQUE added to schema.sql + pglite-schema.ts
for fresh installs
- ON CONFLICT (slug) → ON CONFLICT (source_id, slug) in both pglite-engine
and postgres-engine putPage
- DEFAULT 'default' closes the Codex-flagged race where an INSERT between
ADD COLUMN and SET NOT NULL could leave source_id NULL
- 5 new v17 structural tests (29 pass / 0 fail in migrate.test.ts)
- Full suite: 1979 pass / 3 fail (same as baseline — no regressions)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 6/9): sources CLI + source-resolver (Lane C)
Adds the CLI surface for multi-source management. Users can now register,
list, rename, federate/unfederate, and attach-to-directory a source. The
source-resolver is the shared 6-priority helper that Steps 4/5 will use
when they start surfacing an explicit --source flag on sync/extract/query.
Commands:
gbrain sources add <id> --path <p> [--name <n>] [--federated|--no-federated]
gbrain sources list [--json]
gbrain sources remove <id> [--yes] [--dry-run] [--keep-storage]
gbrain sources rename <id> <new-name>
gbrain sources default <id>
gbrain sources attach <id> — writes .gbrain-source in CWD
gbrain sources detach
gbrain sources federate <id> / unfederate <id>
Resolution priority (source-resolver.ts) — highest first:
1. --source flag 2. GBRAIN_SOURCE env 3. .gbrain-source dotfile walk-up
4. longest-prefix match on registered local_path (Codex #2 fix)
5. sources.default config 6. fallback 'default'
- add: validates id format (kebab-case alnum, 1-32), rejects overlapping
paths (eng review §4 finding 4.1), supports federated default opt-in
- remove: guards against --yes omission + refuses to remove 'default',
supports --dry-run, reports cascade page count
- attach/detach: matches kubectl/terraform context-pinning semantics
- Throws on overlap rather than process.exit() so the CLI error wrapper
reports it consistently (also makes unit testing clean)
28 new tests across sources.test.ts (dispatcher + validation + overlap
guard) and source-resolver.test.ts (full 6-priority coverage including
longest-prefix). Full suite: 2012 pass / 3 fail (pre-existing PGLite
infra timeouts).
NOT in scope for Step 6 (deferred):
- import-from-github (SSRF + clone integration)
- prune (retention/TTL, lands v0.18)
- MCP tool-defs regen for source-scoping on read ops (Step 5)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* docs(v0.17.0 step 8/9): getting-started guide + migration skill + citation rule
Step 8 (Lane F) documents what Steps 1+2+6 have shipped and sets up
the agent-facing rules for multi-source.
New files:
- skills/migrations/v0.17.0.md — migration skill read by host agents
after `gbrain apply-migrations`. Covers the v16+v17 chain, what's
in v0.17.0 vs what lands later (v0.17.1 ACL, v0.18 sessions), and
the new sources CLI surface. Cites docs/guides/multi-source-brains.md
as the recipe.
- docs/guides/multi-source-brains.md — getting-started for end users.
Three canonical scenarios (unified wiki+gstack / purpose-separated
yc-media+garrys-list / mixed), full resolution priority, federation
flag semantics, command reference, and citation format.
skills/brain-ops/SKILL.md — new "Cross-source citation format"
section mandating `[source-id:slug]` when the brain has multiple
sources. Matches the contract the /plan-devex-review DX review
pinned down (DX Finding 5: surface source_id in every page payload
+ citation contract). Key must be sources.id (immutable), never
sources.name.
No behavior change — this is pure documentation for what already
exists in the binary. 144 skills conformance tests still pass.
NOT in this commit (deferred to later steps):
- docs/guides/repo-architecture.md rewrite (lands with the full
v0.17.0 PR description + release notes)
- skills/_brain-filing-rules.md "which source to file into"
guidance (lands with Step 5 when sync surfaces --source)
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 5/9): sync --source <id> routes through sources table (Lane D)
Adds the --source flag to `gbrain sync`. When set, sync reads local_path
+ last_commit from the matching sources(id) row instead of the global
sync.repo_path / sync.last_commit config keys, and writes last_commit +
last_sync_at back to the same row. Backward compat: --source omitted =
pre-v0.17 behavior exactly, global config path unchanged.
- SyncOpts.sourceId threaded through performSync + performFullSync
- readSyncAnchor/writeSyncAnchor helpers centralize the sources-vs-config
branch so every read/write goes through one decision point. Makes
Step 5's later per-source sync-failures tracking a one-file change.
- --source resolved via src/core/source-resolver.ts (Step 6), so any
command that shell-exposes resolveSourceId gets env var + dotfile
walk-up + longest-prefix for free.
- Error message for missing source local_path is actionable:
Source "gstack" has no local_path. Run: gbrain sources add gstack --path <path>
- last_sync_at auto-updates on every last_commit advance so `gbrain
sources list` shows real recency.
No regression: 2012 pass / 3 fail (same as baseline).
NOT in this commit (deferred per plan):
- Per-source failure tracking (~/.gbrain/sources/<id>/sync-failures.jsonl)
- runImport source-awareness (import.ts path — Step 5 continuation)
- Partial-success semantics when walking N sources — single-source flow
today, multi-walk lands when the top-level `gbrain sync` without
--source starts iterating all sources.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 4/9): qualified [[source:slug]] + links.resolution_type (Lane B)
Adds source-pinned wikilink syntax and records the resolution kind on
each edge so `gbrain extract --refresh-unqualified` (future) can
re-resolve bare references when the source topology changes.
Wikilink syntax extension:
[[concepts/ai]] — unqualified; resolves via local-first fallback
[[wiki:concepts/ai]] — qualified; target pinned to sources.id='wiki'
[[gstack:projects/foo|Display]] — qualified + display name
The qualified regex runs first and masks matched spans so the
unqualified pass can't double-emit. Source id format enforced to match
the sources CLI validation: [a-z0-9](?:[a-z0-9-]{0,30}[a-z0-9])?
Schema:
- migration v18 adds links.resolution_type TEXT with CHECK constraint
('qualified'|'unqualified' or NULL for legacy/manual/frontmatter edges)
- schema.sql + pglite-schema.ts updated for fresh installs
EntityRef type:
- sourceId is OPTIONAL (only set on qualified wikilinks). Markdown
[Name](path) and unqualified wikilinks omit it so strict toEqual
tests pre-v0.17 keep working (69 existing tests still pass).
Tests:
- 5 new qualified-wikilink extraction tests + 1 migration v18 structural
assertion. 75 tests in test/link-extraction.test.ts (up from 69).
- Full suite: 2018 pass / 3 fail (pre-existing PGLite infra timeouts).
NOT in this commit (deferred to Step 3 / Step 5 continuation):
- Writing resolution_type to the DB (addLink / addLinksBatch don't
carry the field yet — that's the plumb-through that lands with
Step 3 when search/dedup also needs source-aware result keys).
- `gbrain extract --refresh-unqualified` re-resolver.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 3/9): source-aware search dedup composite keys (Lane B)
Search dedup now keys on (source_id, slug) instead of slug alone. Pre-
v0.17 would collapse two same-slug pages in different sources into
one, destroying cross-source recall. Codex outside-voice review flagged
this as regression-critical — this commit ships the fix plus tests
that lock the invariant in.
Dedup pipeline (src/core/search/dedup.ts):
- pageKey(r) helper — one canonical composite-key derivation. Falls
back to source_id='default' for pre-v0.17 rows so single-source
brains behave identically to before.
- Layer 1 (dedupBySource): group-by composite key.
- Layer 4 (capPerPage): count-by composite key.
- guaranteeCompiledTruth: swap scoped to matching (source_id, slug),
so wiki:topics/ai can't accidentally pull gstack:topics/ai's
compiled_truth chunk.
SearchResult type gains optional source_id — populated by SQL JOINs
in both engines, falls through as 'default' for legacy callers.
Engine SQL:
- pglite-engine.ts + postgres-engine.ts: search SELECTs add p.source_id
- rowToSearchResult (utils.ts): maps row.source_id → result.source_id
when present. Shape stays backward compatible (field optional).
Tests — 4 new in test/dedup.test.ts:
- same-slug-different-source does NOT collapse (the critical regression
guard Codex called out)
- same-slug-same-source DOES still collapse (no over-correction)
- missing source_id falls back to 'default' for pre-v0.17 compat
- compiled_truth guarantee scopes to composite key (Codex second pass
caught this specific path would leak otherwise)
Full suite: 2022 pass / 3 fail (3 pre-existing PGLite infra timeouts).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* feat(v0.17.0 step 7/9): file_migration_ledger + phase-B storage backfill (Lane E)
Adds files.source_id + files.page_id + the file_migration_ledger
state machine that drives storage object rewrites. Each per-file
transition is its own transaction so crash-point recovery is a
ledger read, not a filesystem inspection. Codex second-pass review
flagged that "skip if already has source prefix" was an unsafe
heuristic — the ledger replaces it with explicit state tracking.
Schema:
- migration v19 (files_source_id_page_id_ledger): handler-only
(PGLite has no files table; Postgres-only gate). ADDs
source_id + page_id to files, backfills page_id from page_slug
scoped to source_id='default', creates file_migration_ledger
with PK on file_id (Codex: not storage_path_old — two sources
can share an old path during migration).
- schema.sql updated for fresh Postgres installs; file_migration_ledger
gets RLS alongside other tables.
Runtime:
- src/commands/migrations/v0_17_0-storage-backfill.ts: drives the
ledger state machine pending → copy_done → db_updated → complete.
Idempotent per row: re-running resumes from whichever state
crashed. Old objects preserved (no delete) so operators can
verify the soak window before a future cleanup release.
- phase B in v0_17_0.ts orchestrator: wires the storage backend
(Supabase/S3/local) through createStorage, runs runStorageBackfill,
reports per-state counts + first-three error details.
Tests — 13 new in test/storage-backfill.test.ts:
- pending → copy_done → db_updated → complete happy path
- 3 crash-point recovery tests (resume from copy_done, resume from
db_updated, failed rows don't auto-retry)
- already-complete rows are skipped with zero side effects
- idempotent re-upload (exists-check skips redundant upload)
- dry-run mode (no storage, reports counts without mutating)
Plus 5 new migrate.test.ts assertions for v19 structure (handler-
only, PGLite gate, source_id + page_id + ledger DDL, default-source
backfill scope, state machine values).
Full suite: 2035 pass / 3 fail (3 pre-existing PGLite infra
timeouts).
NOT in this commit (explicitly deferred):
- DROP old page_slug column — kept for backward compat until
operators have time to verify page_id everywhere.
- DROP old UNIQUE(storage_path) in favor of UNIQUE(source_id,
storage_path) — same reason, deferred to later cleanup.
- Actual cleanup phase that deletes old objects post-soak.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(v0.17.0 step 9/9): full multi-source PGLite integration suite (Lane G)
End-to-end exercise of every v0.17.0 surface against real PGLite
(in-memory, fast — no DATABASE_URL needed). The migration chain
v2→v19 runs start-to-finish and the test asserts each Step's
invariants hold together.
16 new integration tests across 7 describes:
1. Migration-installed state:
- sources('default') exists with federated=true config
- pages.source_id column has DEFAULT 'default'
- composite UNIQUE (source_id, slug) is installed
2. Default-source write path:
- putPage without explicit source → source_id='default' via schema
default clause (no engine API change needed for single-source brains)
3. Composite UNIQUE regression guards (Codex-flagged):
- Same slug in two different sources coexists
- Third insert with same (source_id, slug) hits the UNIQUE constraint
4. sources CLI round-trip:
- federate / unfederate flips config.federated
- rename changes display, id stays immutable
5. Source resolution priority (integration):
- Explicit flag > env var > fallback to default
- Unregistered explicit source errors with actionable message
6. Cascade semantics:
- sources remove cascades to pages; default source untouched
7. links.resolution_type (Step 4):
- Qualified/unqualified values accepted
- CHECK constraint rejects invalid values
All 16 tests pass. Full suite: 2042 pass / 4 fail (4 pre-existing
PGLite beforeEach timeouts in test/wait-for-completion,
test/extract-fs, test/e2e/search-quality, test/e2e/graph-quality
— count fluctuated 3-5 on baseline from variance alone).
Total new tests across Steps 1-9: ~85 unit + integration tests
(sources, source-resolver, migrate v16/v17/v18/v19 structural,
link-extraction qualified wikilinks, dedup regression-critical,
storage-backfill state machine + crash recovery, full
multi-source PGLite integration).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* chore: bump to v0.18.0 + CHANGELOG entry (multi-source brains)
One-viewport release summary + itemized changes covering all 9 steps
of the multi-source primitive. Notes the v0.17 → v0.18 version bump
rationale (master shipped gbrain dream as v0.17 while this branch was
in flight).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(ci): v0_18_0 orchestrator TS narrow + mechanical test ON CONFLICT
Two CI failures on PR #337:
1. tsc TS2367 at src/commands/migrations/v0_18_0.ts:190 —
after the early-return on `a.status === 'failed'` (line 179),
TypeScript narrows `a.status` to `'skipped' | 'complete'`, so the
subsequent `a.status === 'failed' ? 'failed' :` branch was dead
code and refused to compile. Dropped the redundant check.
2. E2E `file_list LIMIT enforcement` at test/e2e/mechanical.test.ts:636 —
the test pre-seeded a pages row with `ON CONFLICT (slug) DO NOTHING`
but v21 swapped the global UNIQUE for `UNIQUE (source_id, slug)`, so
Postgres rejects with "no unique or exclusion constraint matching".
Updated the conflict target to the composite key.
Tier-1 E2E had only this one failing test; everything else passed.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* test(e2e): v0.18.0 multi-source against real Postgres (v20-v23 schema + cascade + sync)
Closes the three biggest confidence gaps the author flagged in the
self-audit of PR #337:
1. No real Postgres E2E — PGLite has no files table, so v23's
files.source_id + files.page_id rewrite + file_migration_ledger
seed was NEVER executed against the real DB. This file covers it.
2. `gbrain sync --source <id>` had zero direct tests. Now has two:
one that asserts performSync({sourceId}) reads local_path from the
sources row (not the global config), one that asserts no-sourceId
falls back to the global sync.repo_path.
3. Cascade delete coverage — previously verified only pages count
after source removal. Now verifies pages + content_chunks +
timeline_entries + links + files ALL cascade-delete when a source
is removed.
6 describes, 16 tests total:
- Schema shape (fresh install): 6 tests confirming sources('default'),
pages.source_id NOT NULL with DEFAULT, composite UNIQUE pages
(source_id, slug) replaces global UNIQUE(slug), links.resolution_type
column + CHECK, files.source_id + page_id columns, file_migration_ledger
table + status CHECK.
- Composite UNIQUE semantics: 3 tests confirming same-slug in two
sources coexists (Codex-critical regression guard), duplicate
(source_id, slug) hits the UNIQUE, putPage targets default source
by schema DEFAULT.
- Cascade delete: 1 test building a fully populated source (2 pages,
chunks, timeline, links, files) then removing it + asserting every
dependent row is gone.
- Sync routing: 2 tests confirming performSync({sourceId}) reads
per-source local_path vs global config.
- Sources surface: 3 tests for federate/unfederate flipping + rename
preserving id.
- Storage backfill: 1 end-to-end test seeding ledger + running
runStorageBackfill against a stub StorageBackend, asserting
pending → complete transition and files.storage_path rewrite.
Gated by DATABASE_URL per CLAUDE.md E2E lifecycle. Each describe's
beforeAll defensively DELETEs non-default sources + file_migration_ledger
rows so reruns are hermetic (sources isn't in helpers.ALL_TABLES).
Verified: 16/16 pass on first run AND second run (residual-state fix
holds). Full E2E suite still green.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(ci): TS2352 in multi-source E2E — cast postgres.js RowList via unknown
tsc rejects the direct
`(rows as { column_name: string }[]).map(...)`
cast because postgres.js RowList rows have an iterable-row shape that
doesn't overlap with the plain-object target. Standard fix: cast via
`unknown` first so the narrowing is explicit.
Verified: `bunx tsc --noEmit` clean (ignoring the pre-existing baseUrl
deprecation warning).
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
* fix(v0.18.0): addLinksBatch + addTimelineEntriesBatch source-aware JOINs
Batch APIs JOINed on pages.slug globally, so two pages sharing the same
slug across sources would silently fan out — addLinksBatch(['a->b']) in
a brain with 'a' in both 'default' and 'alt' wrote 2 edges instead of 1.
Same bug on addTimelineEntriesBatch.
Fix:
- LinkBatchInput + TimelineBatchInput gain optional source_id fields
(from_source_id, to_source_id, origin_source_id for links; source_id
for timeline). All default to 'default' so existing callers are
backward-compatible on single-source brains.
- pglite-engine + postgres-engine batch JOINs now composite-key on
(slug, source_id). Postgres adds 3 more unnest arrays for links + 1
for timeline — still one bind per column, no 65535-param cap risk.
- LEFT JOIN for origin pages also source-qualified so frontmatter-
provenance edges don't cross-pollinate across sources.
Regression coverage:
- test/pglite-engine.test.ts: 5 new tests covering default-path isolation,
explicit alt-source writes, and cross-source edges.
- test/e2e/multi-source.test.ts: 4 new tests against real Postgres so
postgres-js's unnest() bind path is exercised (structurally different
from PGLite's).
Gap #4 from the PR self-audit — latent bug, not previously reachable
because every existing caller wrote to the default source only.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
---------
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
253 lines
10 KiB
TypeScript
253 lines
10 KiB
TypeScript
/**
|
|
* v0.18.0 Step 6 — sources CLI subcommand tests.
|
|
*
|
|
* Pure unit tests that exercise the subcommand dispatcher via a
|
|
* stub BrainEngine. No DB required — we just confirm the SQL
|
|
* shape, validation, and flag parsing.
|
|
*/
|
|
|
|
import { describe, test, expect, beforeEach } from 'bun:test';
|
|
import { runSources } from '../src/commands/sources.ts';
|
|
import type { BrainEngine } from '../src/core/engine.ts';
|
|
|
|
// ── Stub engine that records queries ───────────────────────
|
|
|
|
interface RecordedCall {
|
|
sql: string;
|
|
params: unknown[];
|
|
}
|
|
|
|
function makeStub(rowsByPattern: Record<string, unknown[]> = {}): {
|
|
engine: BrainEngine;
|
|
calls: RecordedCall[];
|
|
configSet: Array<{ key: string; value: string }>;
|
|
} {
|
|
const calls: RecordedCall[] = [];
|
|
const configSet: Array<{ key: string; value: string }> = [];
|
|
|
|
const executeRaw = async (sql: string, params?: unknown[]) => {
|
|
calls.push({ sql, params: params ?? [] });
|
|
// Match by substring so tests are robust against whitespace.
|
|
for (const [pattern, rows] of Object.entries(rowsByPattern)) {
|
|
if (sql.includes(pattern)) return rows as never;
|
|
}
|
|
return [] as never;
|
|
};
|
|
|
|
const setConfig = async (key: string, value: string) => {
|
|
configSet.push({ key, value });
|
|
};
|
|
|
|
// Minimal BrainEngine stub — only the methods sources.ts touches.
|
|
const engine = {
|
|
kind: 'pglite' as const,
|
|
executeRaw,
|
|
setConfig,
|
|
// Unused methods throw if called accidentally during these tests.
|
|
getConfig: async () => null,
|
|
} as unknown as BrainEngine;
|
|
|
|
return { engine, calls, configSet };
|
|
}
|
|
|
|
// ── add ─────────────────────────────────────────────────────
|
|
|
|
// Intercept process.exit so unit tests under bun:test don't actually
|
|
// exit. Each test that might trigger process.exit() wraps its call in
|
|
// `withExitCapture`. We only return when the function under test returns
|
|
// or throws; process.exit() is turned into a recoverable throw.
|
|
async function withExitCapture(fn: () => Promise<void>): Promise<number | null> {
|
|
const origExit = process.exit;
|
|
let captured: number | null = null;
|
|
process.exit = ((code?: number) => {
|
|
captured = code ?? 0;
|
|
throw new Error('__process_exit__');
|
|
}) as never;
|
|
try {
|
|
await fn();
|
|
} catch (e) {
|
|
if (!(e instanceof Error) || !e.message.includes('__process_exit__')) throw e;
|
|
} finally {
|
|
process.exit = origExit;
|
|
}
|
|
return captured;
|
|
}
|
|
|
|
describe('sources add', () => {
|
|
test('rejects invalid ids', async () => {
|
|
const { engine } = makeStub();
|
|
const code = await withExitCapture(() => runSources(engine, ['add']));
|
|
expect(code).toBe(2);
|
|
});
|
|
|
|
test('rejects uppercase / invalid chars in id', async () => {
|
|
const { engine } = makeStub();
|
|
await expect(runSources(engine, ['add', 'BadId', '--path', '/tmp/x'])).rejects.toThrow(/Invalid source id/);
|
|
});
|
|
|
|
test('rejects id longer than 32 chars', async () => {
|
|
const { engine } = makeStub();
|
|
const long = 'a'.repeat(33);
|
|
await expect(runSources(engine, ['add', long, '--path', '/tmp/x'])).rejects.toThrow(/Invalid source id/);
|
|
});
|
|
|
|
test('inserts a valid source with defaults (federated unset → isolated)', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [{
|
|
id: 'gstack',
|
|
name: 'gstack',
|
|
local_path: '/tmp/gstack',
|
|
last_commit: null,
|
|
last_sync_at: null,
|
|
config: '{}',
|
|
created_at: new Date(),
|
|
}],
|
|
});
|
|
await runSources(engine, ['add', 'gstack', '--path', '/tmp/gstack']);
|
|
const insert = calls.find(c => c.sql.includes('INSERT INTO sources'));
|
|
expect(insert).toBeDefined();
|
|
expect(insert!.params[0]).toBe('gstack');
|
|
expect(insert!.params[1]).toBe('gstack'); // name defaults to id
|
|
expect(insert!.params[2]).toBe('/tmp/gstack');
|
|
expect(insert!.params[3]).toBe('{}'); // federated unset → empty config
|
|
});
|
|
|
|
test('--federated sets config.federated = true', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [{
|
|
id: 'wiki',
|
|
name: 'wiki',
|
|
local_path: '/tmp/wiki',
|
|
last_commit: null,
|
|
last_sync_at: null,
|
|
config: '{"federated":true}',
|
|
created_at: new Date(),
|
|
}],
|
|
});
|
|
await runSources(engine, ['add', 'wiki', '--path', '/tmp/wiki', '--federated']);
|
|
const insert = calls.find(c => c.sql.includes('INSERT INTO sources'));
|
|
expect(insert!.params[3]).toBe('{"federated":true}');
|
|
});
|
|
|
|
test('--no-federated sets config.federated = false (isolation opt-in)', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [{
|
|
id: 'yc-media',
|
|
name: 'yc-media',
|
|
local_path: '/tmp/yc',
|
|
last_commit: null,
|
|
last_sync_at: null,
|
|
config: '{"federated":false}',
|
|
created_at: new Date(),
|
|
}],
|
|
});
|
|
await runSources(engine, ['add', 'yc-media', '--path', '/tmp/yc', '--no-federated']);
|
|
const insert = calls.find(c => c.sql.includes('INSERT INTO sources'));
|
|
expect(insert!.params[3]).toBe('{"federated":false}');
|
|
});
|
|
|
|
test('rejects overlapping paths (per eng review finding 4.1)', async () => {
|
|
const { engine } = makeStub({
|
|
'SELECT id, local_path FROM sources WHERE local_path': [
|
|
{ id: 'gstack', local_path: '/tmp/gstack' },
|
|
],
|
|
});
|
|
// New source at /tmp/gstack/plans is inside existing gstack at /tmp/gstack.
|
|
await expect(runSources(engine, ['add', 'plans', '--path', '/tmp/gstack/plans']))
|
|
.rejects.toThrow(/overlaps with existing source "gstack"/);
|
|
});
|
|
});
|
|
|
|
// ── list ────────────────────────────────────────────────────
|
|
|
|
describe('sources list', () => {
|
|
test('orders default source first, then alphabetical', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'default', name: 'default', local_path: null, last_commit: null, last_sync_at: null, config: '{"federated":true}', created_at: new Date() },
|
|
],
|
|
'COUNT(*)::int AS n FROM pages': [{ n: 0 }],
|
|
});
|
|
await runSources(engine, ['list']);
|
|
const select = calls.find(c => c.sql.includes('ORDER BY (id = \'default\') DESC'));
|
|
expect(select).toBeDefined();
|
|
});
|
|
});
|
|
|
|
// ── remove ──────────────────────────────────────────────────
|
|
|
|
describe('sources remove', () => {
|
|
test("refuses to remove the 'default' source", async () => {
|
|
const { engine } = makeStub();
|
|
const code = await withExitCapture(() => runSources(engine, ['remove', 'default', '--yes']));
|
|
expect(code).toBe(3);
|
|
});
|
|
|
|
test('refuses without --yes', async () => {
|
|
const { engine } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'gstack', name: 'gstack', local_path: '/tmp/g', last_commit: null, last_sync_at: null, config: '{}', created_at: new Date() },
|
|
],
|
|
'COUNT(*)::int AS n FROM pages': [{ n: 10 }],
|
|
});
|
|
const code = await withExitCapture(() => runSources(engine, ['remove', 'gstack']));
|
|
expect(code).toBe(5);
|
|
});
|
|
|
|
test('--dry-run reports but does not DELETE', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'gstack', name: 'gstack', local_path: '/tmp/g', last_commit: null, last_sync_at: null, config: '{}', created_at: new Date() },
|
|
],
|
|
'COUNT(*)::int AS n FROM pages': [{ n: 10 }],
|
|
});
|
|
await runSources(engine, ['remove', 'gstack', '--dry-run']);
|
|
const del = calls.find(c => c.sql.startsWith('DELETE FROM sources'));
|
|
expect(del).toBeUndefined();
|
|
});
|
|
});
|
|
|
|
// ── default ─────────────────────────────────────────────────
|
|
|
|
describe('sources default', () => {
|
|
test("stores id in config key 'sources.default'", async () => {
|
|
const { engine, configSet } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'gstack', name: 'gstack', local_path: null, last_commit: null, last_sync_at: null, config: '{}', created_at: new Date() },
|
|
],
|
|
});
|
|
await runSources(engine, ['default', 'gstack']);
|
|
expect(configSet).toEqual([{ key: 'sources.default', value: 'gstack' }]);
|
|
});
|
|
});
|
|
|
|
// ── federate / unfederate ──────────────────────────────────
|
|
|
|
describe('sources federate / unfederate', () => {
|
|
test('federate sets config.federated = true', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'gstack', name: 'gstack', local_path: null, last_commit: null, last_sync_at: null, config: '{}', created_at: new Date() },
|
|
],
|
|
});
|
|
await runSources(engine, ['federate', 'gstack']);
|
|
const upd = calls.find(c => c.sql.includes('UPDATE sources SET config'));
|
|
expect(upd).toBeDefined();
|
|
expect(JSON.parse(upd!.params[0] as string)).toEqual({ federated: true });
|
|
});
|
|
|
|
test('unfederate preserves other config keys', async () => {
|
|
const { engine, calls } = makeStub({
|
|
'SELECT id, name, local_path, last_commit, last_sync_at, config, created_at': [
|
|
{ id: 'gstack', name: 'gstack', local_path: null, last_commit: null, last_sync_at: null, config: '{"ttl_days":90,"federated":true}', created_at: new Date() },
|
|
],
|
|
});
|
|
await runSources(engine, ['unfederate', 'gstack']);
|
|
const upd = calls.find(c => c.sql.includes('UPDATE sources SET config'));
|
|
const parsed = JSON.parse(upd!.params[0] as string);
|
|
// Must preserve ttl_days while flipping federated.
|
|
expect(parsed.ttl_days).toBe(90);
|
|
expect(parsed.federated).toBe(false);
|
|
});
|
|
});
|