* fix(subagent): bind Anthropic SDK messages.create() correctly The makeSubagentHandler was casting `new Anthropic()` directly to MessagesClient, but MessagesClient.create() maps to sdk.messages.create(), not sdk.create(). Every subagent job immediately died with: client.create is not a function Fix: wrap the SDK instance so .create() delegates to .messages.create() with proper `this` binding via .bind(sdk.messages). Discovered on first production run of gbrain agent against Supabase. Co-Authored-By: Wintermute <wintermute@openclaw.ai> * chore(ci): add typescript typecheck to test pipeline + clean up baseline errors Root cause infra gap that let the v0.16.0 subagent bug ship: CI ran only `bun test`, which transpiles types without checking them. Type errors only surfaced at runtime, in production. Changes: - Add `typescript` devDep and a `typecheck` npm script (`tsc --noEmit`). - Chain `bun run typecheck` into `bun run test` so developers get the same pipeline locally that CI runs. - Flip `.github/workflows/test.yml` to invoke `bun run test` (the npm script, including typecheck) instead of `bun test` (runner only). - Clean up 100+ pre-existing type errors across 30+ files so the first run of `tsc --noEmit` is green. Root causes were: - `databaseUrl` → `database_url` rename drift in test fixtures (9 files) - `PageType` union missing `'meeting'` / `'note'` entries that are already used in both src and tests (link-extraction.ts comments acknowledged the gap) - `GBrainConfig.storage` field never declared despite being read in files.ts and operations.ts - `ErrorCode` union missing `'permission_denied'` - `OrchestratorOpts` shape changed; test callers not updated - Dead-code comparisons in migration orchestrators against narrowed status types - postgres.js `Row`-callback type drift on several `.map()` calls - Buffer-as-BodyInit assignment in supabase.ts (real but non-fatal runtime bug; Uint8Array slice works and is type-correct) - Various `as X` single-step casts that now need `as unknown as X` per TS's stricter structural-conversion rules - Bump `beforeAll` hook timeout to 30s on four PGLite-heavy tests that were flaky under parallel test execution: wait-for-completion, extract-fs, e2e/search-quality, e2e/graph-quality. All pass in isolation; timeouts only happened when dozens of PGLite instances init'd simultaneously. The new CI pipeline now fails on any type error across src/ or test/, giving us the compile-time regression guard the subagent fix depends on. * fix(subagent): bind Anthropic SDK messages.create() correctly Shipped bug: v0.16.0 cast `new Anthropic()` to `MessagesClient`, but `.create()` lives at `sdk.messages.create`, not on the top-level client. Every subagent job in production died on first LLM call with `client.create is not a function`. Discovered on the first `gbrain agent run` against Supabase. Fix: assign `sdk.messages` directly to the `MessagesClient` slot. `sdk.messages` IS the object with a callable `.create()`; the original bug was picking the wrong entry point on the SDK. No helper, no wrapper, no `.bind()` — JS method-call semantics preserve `this` at the call site because `subagent.ts:336` invokes `client.create(...)` with `client === sdk.messages`. The one-line assignment also typechecks cleanly against the existing `MessagesClient` interface (SDK's first `create` overload: `(MessageCreateParamsNonStreaming, Core.RequestOptions?) => APIPromise<Message>` is assignable structurally). This gives us compile-time regression protection: anyone reverting to `new Anthropic()` would fail tsc because `Anthropic` has no top-level `.create`. (The companion chore commit puts `tsc --noEmit` in CI so this guard is enforced.) Also adds a `makeAnthropic?: () => Anthropic` dep-injection seam so the factory default construction branch is testable without real API calls. Regression test drives one handler turn through a fake SDK, asserting `sdk.messages.create` is actually called. If someone later reverts to `new Anthropic()`, both guards fire: tsc fails AND the test fails. Co-Authored-By: Wintermute <wintermute@garrytan.com> * chore(tests): add bunfig.toml + 60s hook timeouts to stabilize PGLite-heavy suites After turning on tsc in CI (previous commit), running the full `bun run test` suite in one shot triggered flaky `beforeEach/afterEach hook timed out` failures on 8+ test files. Every failure traced to PGLite WASM init contention when many test files spin up fresh PGLite instances in parallel; each one alone passes in isolation. - `bunfig.toml` sets the global test hook timeout to 60s (default is 5s), covering every test file without per-file edits. - Individual `beforeAll(fn, 60_000)` / `beforeEach(fn, 15_000)` calls on the 8 tests that flaked most stay in place as explicit safety nets so a future bunfig config change doesn't silently re-introduce the flake. Result: 1997 pass, 0 fail on `bun run test` (117 tests added since the prior baseline by picking up typecheck-gated passes). No infrastructure flake tolerated in CI. * chore: bump version and changelog (v0.16.3) Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Wintermute <wintermute@garrytan.com> Co-authored-by: Wintermute <wintermute@openclaw.ai> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
149 lines
5.1 KiB
TypeScript
149 lines
5.1 KiB
TypeScript
/**
|
|
* Lease-based rate limiter tests. Runs against PGLite in-memory.
|
|
*/
|
|
|
|
import { describe, test, expect, beforeAll, afterAll, beforeEach } from 'bun:test';
|
|
import { PGLiteEngine } from '../src/core/pglite-engine.ts';
|
|
import { MinionQueue } from '../src/core/minions/queue.ts';
|
|
import {
|
|
acquireLease,
|
|
renewLease,
|
|
releaseLease,
|
|
renewLeaseWithBackoff,
|
|
} from '../src/core/minions/rate-leases.ts';
|
|
|
|
let engine: PGLiteEngine;
|
|
let queue: MinionQueue;
|
|
let owner: number; // a minion_jobs.id to own leases (FK target)
|
|
|
|
beforeAll(async () => {
|
|
engine = new PGLiteEngine();
|
|
await engine.connect({ database_url: '' });
|
|
await engine.initSchema();
|
|
queue = new MinionQueue(engine);
|
|
});
|
|
|
|
afterAll(async () => {
|
|
await engine.disconnect();
|
|
});
|
|
|
|
beforeEach(async () => {
|
|
await engine.executeRaw('DELETE FROM subagent_rate_leases');
|
|
await engine.executeRaw('DELETE FROM minion_jobs');
|
|
const j = await queue.add('owner', {});
|
|
owner = j.id;
|
|
});
|
|
|
|
describe('acquireLease / releaseLease', () => {
|
|
test('single acquire under cap returns lease id', async () => {
|
|
const r = await acquireLease(engine, 'anthropic:messages', owner, 2);
|
|
expect(r.acquired).toBe(true);
|
|
expect(r.leaseId).toBeGreaterThan(0);
|
|
expect(r.activeCount).toBe(1);
|
|
});
|
|
|
|
test('acquires up to max_concurrent', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 2);
|
|
const b = await acquireLease(engine, 'k', owner, 2);
|
|
expect(a.acquired).toBe(true);
|
|
expect(b.acquired).toBe(true);
|
|
expect(b.activeCount).toBe(2);
|
|
});
|
|
|
|
test('rejects beyond max_concurrent', async () => {
|
|
await acquireLease(engine, 'k', owner, 2);
|
|
await acquireLease(engine, 'k', owner, 2);
|
|
const third = await acquireLease(engine, 'k', owner, 2);
|
|
expect(third.acquired).toBe(false);
|
|
expect(third.leaseId).toBeUndefined();
|
|
expect(third.activeCount).toBe(2);
|
|
});
|
|
|
|
test('releaseLease frees a slot', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1);
|
|
expect(a.acquired).toBe(true);
|
|
const blocked = await acquireLease(engine, 'k', owner, 1);
|
|
expect(blocked.acquired).toBe(false);
|
|
|
|
await releaseLease(engine, a.leaseId!);
|
|
|
|
const after = await acquireLease(engine, 'k', owner, 1);
|
|
expect(after.acquired).toBe(true);
|
|
});
|
|
|
|
test('different keys have independent capacity', async () => {
|
|
const a = await acquireLease(engine, 'k1', owner, 1);
|
|
const b = await acquireLease(engine, 'k2', owner, 1);
|
|
expect(a.acquired).toBe(true);
|
|
expect(b.acquired).toBe(true);
|
|
});
|
|
|
|
test('stale leases auto-prune on next acquire', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1, { ttlMs: 10 });
|
|
expect(a.acquired).toBe(true);
|
|
// Force the lease to be stale.
|
|
await engine.executeRaw(
|
|
`UPDATE subagent_rate_leases SET expires_at = now() - interval '1 minute' WHERE id = $1`,
|
|
[a.leaseId!],
|
|
);
|
|
const b = await acquireLease(engine, 'k', owner, 1);
|
|
expect(b.acquired).toBe(true);
|
|
// Only the fresh lease should remain.
|
|
const rows = await engine.executeRaw<{ count: string }>(
|
|
`SELECT count(*)::text AS count FROM subagent_rate_leases WHERE key = $1`,
|
|
['k'],
|
|
);
|
|
expect(parseInt(rows[0]!.count, 10)).toBe(1);
|
|
});
|
|
|
|
test('owner job deletion cascades lease rows', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1);
|
|
expect(a.acquired).toBe(true);
|
|
await engine.executeRaw(`DELETE FROM minion_jobs WHERE id = $1`, [owner]);
|
|
const rows = await engine.executeRaw<{ count: string }>(
|
|
`SELECT count(*)::text AS count FROM subagent_rate_leases WHERE key = $1`,
|
|
['k'],
|
|
);
|
|
expect(parseInt(rows[0]!.count, 10)).toBe(0);
|
|
});
|
|
|
|
test('releaseLease on a missing id is a no-op (idempotent)', async () => {
|
|
await expect(releaseLease(engine, 99_999)).resolves.toBeUndefined();
|
|
});
|
|
});
|
|
|
|
describe('renewLease', () => {
|
|
test('renewLease bumps expires_at and returns true', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1, { ttlMs: 50 });
|
|
const before = await engine.executeRaw<{ expires_at: string }>(
|
|
`SELECT expires_at FROM subagent_rate_leases WHERE id = $1`,
|
|
[a.leaseId!],
|
|
);
|
|
await new Promise(r => setTimeout(r, 5));
|
|
const ok = await renewLease(engine, a.leaseId!, 120_000);
|
|
expect(ok).toBe(true);
|
|
const after = await engine.executeRaw<{ expires_at: string }>(
|
|
`SELECT expires_at FROM subagent_rate_leases WHERE id = $1`,
|
|
[a.leaseId!],
|
|
);
|
|
expect(new Date(after[0]!.expires_at).getTime()).toBeGreaterThan(new Date(before[0]!.expires_at).getTime());
|
|
});
|
|
|
|
test('renewLease on a missing lease returns false', async () => {
|
|
expect(await renewLease(engine, 99_999)).toBe(false);
|
|
});
|
|
});
|
|
|
|
describe('renewLeaseWithBackoff', () => {
|
|
test('returns true on live lease', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1);
|
|
expect(await renewLeaseWithBackoff(engine, a.leaseId!)).toBe(true);
|
|
});
|
|
|
|
test('returns false on pruned lease (no retry loop)', async () => {
|
|
const a = await acquireLease(engine, 'k', owner, 1);
|
|
await releaseLease(engine, a.leaseId!);
|
|
expect(await renewLeaseWithBackoff(engine, a.leaseId!)).toBe(false);
|
|
});
|
|
});
|