triton6564685/gbrain
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity
198 Commits 2 Branches 0 Tags
03947665e4dbfeaf8a5542d160a0f4b89e4ae747
Commit Graph

3 Commits

Author SHA1 Message Date
Garry Tan
03947665e4 v0.36.0.0 feat(skillpack): scaffold + reference + harvest (retire managed-block install) (#1130) 
* feat(skillpack): extract copyArtifacts shared helper (T1)

Pure file-copy primitive for scaffold (gbrain→host) and harvest (host→gbrain).
Atomic-refusal contract: symlink-reject + canonical-path containment validate
every item before any write. Used by both directions of the v0.33 loop.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): scaffold subcommand + SKILL.md frontmatter sources (T2)

New scaffold.ts replaces the managed-block installer. One-time additive copy
into the user's repo via copyArtifacts; refuses to overwrite existing files
(user owns them). Partial-state policy: copies missing paired sources even
when the skill dir already exists.

bundle.ts extended with loadSkillSources + enumerateScaffoldEntries — paired
source files declared in each SKILL.md's frontmatter sources: array, not in
openclaw.plugin.json. Single source of truth, co-located with the skill.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): reference command + apply-clean-hunks (T4 + T15)

reference is the read-only diff lens with an agent-readable framing line. Pure-JS
unified-diff producer + parser + applier (no patch(1) dependency). Two-way merge
with documented limitation: without scaffold-time base tracking, applied hunks
align everything to gbrain. The agent dry-runs reference first, then decides.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): migrate-fence + scrub-legacy-fence-rows (T5 + T16)

migrate-fence is the one-shot transition from the pre-v0.36 managed-block model.
Strips begin/end markers and the cumulative-slugs receipt comment; preserves
fence rows verbatim as user-owned routing during the transition to frontmatter
discovery. Receipt-then-row fallback (F-CDX-8) covers stale/missing receipts.

scrub-legacy-fence-rows is the opt-in cleanup after migrate-fence. Two-condition
gate: removes a row only when skills/<slug>/ exists AND that skill's frontmatter
declares non-empty triggers (proof frontmatter discovery covers it).

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): harvest + privacy linter (T6 + T7)

The inverse loop: lift a proven skill from a host repo (~/git/wintermute, etc.)
back into gbrain so other clients can scaffold it. --from <host-repo-root> is
symmetric with scaffold's --workspace.

Security: symlink rejection + canonical-path containment (mirrors validateUploadPath).
Privacy: default-on linter scans harvested files against ~/.gbrain/harvest-private-patterns.txt
plus built-in defaults (Wintermute, email, Slack channel patterns). Any match
rolls back the copy and exits non-zero. --no-lint bypasses for the editorial
workflow after a manual scrub.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(repo-root): cwd_walk_up tier for non-OpenClaw hosts (T9 + D3)

autoDetectSkillsDir now walks up from cwd looking for any skills/ directory,
ahead of the implicit ~/.openclaw/workspace fallback. cd ~/git/wintermute &&
gbrain skillpack scaffold ... finds wintermute automatically without requiring
a RESOLVER.md/AGENTS.md to exist yet.

R5 regression preserved: $OPENCLAW_WORKSPACE still wins when explicitly set.
+5 test cases in test/repo-root.test.ts pin the new tier order and the R5 guard.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): rewrite CLI dispatch, drop install + uninstall (T3 + T10)

skillpack.ts dispatcher rewritten for the v0.36 contract: scaffold, reference
(+ --apply-clean-hunks), migrate-fence, scrub-legacy-fence-rows, harvest, plus
the existing list / diff / check.

install and uninstall are gone — both exit non-zero with a hint pointing at
scaffold / migrate-fence. Clean break, no deprecated alias.

skillpack-check gains --strict for CI gating. When invoked as the subcommand
`gbrain skillpack check`, default is informational (exit 0 even with drift);
--strict opts back into the cron-friendly exit-1-on-issues behavior. Top-level
gbrain skillpack-check preserves its existing exit semantics for backwards compat.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skills): skillpack-harvest editorial workflow + resolver wiring (T8)

The companion editorial skill for the gbrain skillpack harvest CLI. Walks the
genericization checklist (scrub fork names, generalize triggers, lift fork-
specific conventions to references) before the CLI runs. Routing-eval fixtures
use paraphrased intents to avoid the intent_copies_trigger lint.

Wires the new slug into openclaw.plugin.json#skills, skills/manifest.json, and
skills/RESOLVER.md.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* test(skillpack): 9-case real-subprocess E2E flow (T11)

Spawns gbrain as a subprocess against tempdir workspaces. Covers: scaffold
first-run + re-run no-op, reference diff + --apply-clean-hunks, migrate-fence,
scrub-legacy-fence-rows, harvest privacy-lint catch + --no-lint bypass, and
the install removed-error path. No DATABASE_URL needed — skillpack is
filesystem-only.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* chore: docs + VERSION + CHANGELOG for v0.36.0.0 (T13 + T14)

Skillpacks as scaffolding, not amber.

v0.36 retires the managed-block install model. Six new subcommands replace
install + uninstall: scaffold, reference (with --apply-clean-hunks), migrate-fence,
scrub-legacy-fence-rows, harvest, plus the existing list / diff / check
(check gains --strict for CI gating). Routing comes from each skill's
frontmatter triggers — gbrain does not touch your RESOLVER.md or AGENTS.md.

Companion editorial skill skillpack-harvest drives the genericization
checklist; default-on privacy linter catches Wintermute / email / Slack
references before they leak into gbrain core.

New docs guide at docs/guides/skillpacks-as-scaffolding.md walks the model
and the migration path for pre-v0.36 installs.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(ci): privacy checks — allow-list harvest-lint tests, scrub user-facing fork-name references

CI's check-privacy.sh and check-test-real-names.sh both flagged the literal
fork name across the v0.36 skillpack diff. Two failure modes, two fixes:

1. **Meta-rule-enforcement files** added to both allow-lists. The harvest
   privacy linter's whole job is to catch the banned literal leaking into
   gbrain; its source has the regex pattern, its tests verify the linter
   fires by feeding it the banned string, and the skill markdown documents
   the substitution policy. Same exception status as check-privacy.sh and
   check-proposal-pii.sh themselves. Files allow-listed:
   - src/core/skillpack/harvest-lint.ts
   - test/skillpack-harvest-lint.test.ts
   - test/skillpack-harvest.test.ts
   - test/e2e/skillpack-flow.test.ts
   - skills/skillpack-harvest/SKILL.md

2. **User-facing references** swapped for canonical phrasing per CLAUDE.md's
   responsible-disclosure rule. README + new docs guide + 4 src docstrings
   + 1 test now say 'your OpenClaw' / 'host agent repo' / 'agentRepo' var
   name. Behavior unchanged — only documentation strings touched.

Verify gate (the script CI runs) passes locally: EXIT=0.
Tests still pass: 60/60 across the affected files.
llms-full.txt regenerated.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(test): update check-resolvable-cli expectation for cwd_walk_up tier

Sister fix to the test/repo-root.test.ts update in commit a31418e3. The new
v0.33 cwd_walk_up tier fires before repo_root when running from inside the
gbrain repo — same skills/ dir matched, different source label. Behavior
unchanged; the legacy repo_root tier is now functionally subsumed (kept in
the type union for back-compat).

CI shard 3 failure: test/check-resolvable-cli.test.ts:171.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* fix(test): pin clock in sync_freshness boundary tests (CI flake)

The 24h and 72h exact-boundary tests scheduled last_sync_at relative to
Date.now() at construction time, then let the check call Date.now() again
internally. CI scheduler jitter between the two reads pushed ageMs past
the strict > thresholds by microseconds, dropping the 72h-boundary case
into the fail branch instead of warn.

Fix: add an optional `opts.now` test seam to checkSyncFreshness. The two
boundary tests now capture t0 once and pass it both to the timestamp
constructor and to the check, making ageMs deterministically equal to
the boundary. The non-boundary tests (4d, 30h, 2h, etc.) don't need
pinning — they're comfortably away from the > comparison.

CI shard 1 flake: test/doctor.test.ts:479. Locally 48/48 doctor tests pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): agent-onboarding readme + next-action hints on every CLI surface (DX review)

DX audit of the v0.36 scaffold model surfaced one structural gap and four
output gaps. When scaffolded files land on a downstream agent's disk, the
agent had no agent-facing manifest telling it what to do — no routing
contract, no upgrade flow, no two-way merge warning at the right surface.

Fixes:

1. **New shared dep: skills/_AGENT_README.md.** Lands on every scaffold +
   migrate-fence alongside the existing _brain-filing-rules.md and
   _output-rules.md. Short, agent-readable contract: walk *.SKILL.md
   frontmatter triggers: for routing, gbrain is reference not law on
   upgrade, no managed-block fence anymore, two-way merge has known
   limitations. Single source of truth for the agent operating contract.

2. **scaffold stdout** prints a next-action hint pointing at the readme
   (with absolute path) and the reference --all upgrade-sweep command.

3. **reference stdout** adds per-category decision policy:
   - missing → scaffold again
   - differs → was edit intentional? keep it. Accidental? patch by hand or
     apply-clean-hunks after reading the two-way warning.

4. **reference --apply-clean-hunks** prints the two-way merge WARNING
   BEFORE the apply (to stderr, survives stdout redirect). Spells out
   that gbrain has no scaffold-time base and local edits in differing
   sections WILL be aligned to gbrain. Skipped in --json mode for
   machine consumers. On conflicts, prints how to inspect and patch.

5. **migrate-fence stdout** tells the agent its routing model just
   changed (fence gone, walk frontmatter now) and points at
   scrub-legacy-fence-rows as the eventual cleanup. References the new
   _AGENT_README for fresh-install agents.

Smoke verified end-to-end: 16 files land (was 15, +1 for _AGENT_README),
hint prints with absolute path, readme lands on disk. Tests + verify gate
pass clean.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* feat(skillpack): upgrade-time reference sweep + reference --since version filter (DX deferred items)

Closes the last two DX gaps from the v0.36 audit:

1. **Post-upgrade reference sweep.** New `postUpgradeReferenceSweep`
   helper called at the end of `gbrain post-upgrade`. After migrations
   apply, auto-runs `reference --all` against the detected host
   workspace and prints a one-line-per-skill summary of drift. Five
   gates: GBRAIN_SKIP_REFERENCE_SWEEP env-var bypass, no detected
   workspace (silent), workspace IS gbrain repo (dev-mode silent),
   zero drift (silent), and pure-missing skills the host never
   scaffolded are filtered out as noise. All errors swallowed —
   never blocks post-upgrade. Helper accepts test-seam opts
   (gbrainRoot, targetWorkspace) for unit testability.

2. **`reference --all --since <version>`.** Filters the sweep to
   skills whose source actually changed in gbrain between
   <version> and HEAD, using a new `changedSlugsSinceVersion`
   helper in bundle.ts. Pure-JS git wrapper (spawnSync), no deps.
   Accepts bare '0.X.Y.Z' or 'v0.X.Y.Z' or commit SHA. Falls back
   loudly to full sweep when git can't resolve the ref (tarball
   install, missing tag).

Test coverage added — total +32 new test cases:

UNIT (15 cases):
- test/skillpack-changed-since-version.test.ts (9 cases): git-aware
  filter against a fixture git repo. Covers null on non-repo,
  null on bad tag, empty array on no changes, single + multi-slug
  drift (deduped + sorted), bare + v-prefix version forms, non-
  skills/ path filtering, SHA-prefix ref form.
- test/upgrade-reference-sweep.test.ts (6 cases): gate logic.
  Covers env-var bypass, zero drift, empty-host suppression,
  drift-detected output shape, dev-mode workspace==gbrain guard,
  error-swallowing contract.

E2E (8 new cases in test/e2e/skillpack-flow.test.ts):
- 10: scaffold lands skills/_AGENT_README.md
- 11: scaffold stdout prints the Next: hint
- 12: scaffold re-run (skipped-existing) suppresses the hint
- 13: reference stdout prints per-category decision policy
- 14: --apply-clean-hunks WARNING on stderr, not stdout
- 15: --apply-clean-hunks --json suppresses the WARNING (bug fix
  surfaced here: code originally printed unconditionally, now
  gated on !json)
- 16: migrate-fence stdout points at the new routing model
- 17: --since with a bad tag falls back to full sweep with warn

Local sweep: 579/579 pass across 18 affected test files, verify
gate EXIT=0, llms regenerated.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(README): zero-base rewrite — 921 → 422 lines, refreshed catalog, MECE structure

The README had drifted into a changelog dumping ground. Four 'New in vX.Y'
paragraphs competed for the lead, 16 version tags scattered through
headings, the production-numbers hook (17,888 pages, 4,383 people) was
six months stale, and skills were described in three places (Skills section,
Commands section, inline marketing prose).

Zero-based rewrite:

**Refreshed catalog** (surveyed live brain + live agent fork, broad strokes
per CLAUDE.md privacy rules):
- ~100K total brain items (was 17,888 in the old README — 6x stale)
- ~16K people (was 4,383)
- ~5K companies (was 723)
- ~8K concepts, ~4K originals, ~3.5K daily notes
- ~31K media (30K tweets, 179 books, papers/films/games/interviews)
- 108 cron jobs running (was 21)
- 273 skills in the live agent fork (35 bundled + 238 user-built)

**Structure** — MECE, single source of truth per concept:
1. Hook + at-a-glance table (refreshed numbers)
2. Install (3 paths, terse)
3. What it does (5 capability areas — replaces 12 scattered sections)
4. Skills (categorized one-liners — 35 lines, was ~200)
5. How it works (one coherent flow — replaces 4 overlapping sections:
   Architecture, Knowledge Model, Knowledge Graph, Search, Why It Works)
6. Commands (terse cheatsheet — every command, one line each)
7. Docs (link map — points to docs/ for the heavy stuff)
8. Origin / Contributing / License

**Cut entirely** (moved or deleted):
- 4 'New in vX.Y' leads (→ CHANGELOG.md is the changelog)
- 16 (vX.Y) version tags in section headings
- Minions stats subsection (subsumed into hook + 'durable background work')
- Voice section (was 12 lines of brand prose)
- Engine Architecture detail (→ docs/architecture/)
- File Storage section (→ docs/guides/storage-tiering.md)
- Per-skill marketing prose (one-liner per skill in the table)

The README is no longer the changelog. Future releases append to
CHANGELOG.md; the README only changes when a structural capability does.

llms-full.txt regenerated. Privacy check + verify gate pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(README): fix line-start '+' rendering bug + lead with eval evidence

Two fixes in one:

1. **Markdown bug fix.** The OAuth 2.1 paragraph had `+ PKCE,` on a line
   start (column 1), which GitHub-flavored markdown interprets as a list
   marker — the line break before it broke the paragraph and rendered as
   an orphan first line followed by a bullet. Rewrote the OAuth 2.1
   capabilities as inline-comma-separated, escaped the `+` semantics.
   Swept the whole file for the same bug class — no other instances.

2. **Maximum-sell mode for evals.** Surveyed every published benchmark
   in both this repo and ~/git/gbrain-evals. Strongest evidence pulled
   to the top:

   - **97.60% R@5 on the public LongMemEval _s (500 questions).** No LLM
     in the retrieval loop. $0.50 per 1000 queries. Beats MemPalace raw
     by a point on the same dataset, beats every academic dense
     retriever (Stella, Contriever, BM25). Mastra/Supermemory measure
     a different metric (QA accuracy with LLM judge) — flagged honestly.

   - **+31.4 points P@5 from the self-wiring knowledge graph** on
     BrainBench v0.20.0 (240-page rich-prose corpus, 145 relational
     gold queries). Separable, measured, load-bearing. Zero retrieval
     regression across seven releases (v0.16 → v0.20).

   New '## Benchmarks' section after Install:
   - Public benchmark table with cross-system comparison
   - In-house BrainBench scorecard with per-adapter Δ vs gbrain
   - Source-swamp resistance result (93.3% top-1 vs 80% grep-only)
   - Skill/prompt compression: 25KB → 13KB AGENTS.md, +13-17pp accuracy
     across Opus 4.7 / Sonnet 4.6 / Haiku 4.5
   - 'Run your own evals' subsection with copy-pasteable commands for
     every eval surface (longmemeval, cross-modal, eval capture/replay,
     BrainBench)

   Tightened the lead's cost-comparison claim to what's defensible per
   the underlying eval doc (MemPal LLM-rerank $0.001/q vs gbrain
   $0.0005/q; dropped the overstated '6x' I'd written initially).

Privacy + verify gate + build-llms test all pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(README): integrate the eval story into the lead, move jargon into 'Receipts on the evals'

Previous lead dumped metric acronyms (R@5, P@5, P@5 deltas, MemPalace,
Stella, Contriever, BM25) before the reader knew what gbrain does. A
'somewhat technical' reader hits the wall of jargon and bounces.

Rewritten:

**Lead (jargon-free, 3 paragraphs)** — describes the value in plain
English, with two anchor numbers:
- 'right answer in top 5 results 97.6% of the time' (not 'R@5 97.60%')
- 'roughly 4x more relevant than plain vector RAG' (not '+31.4 pts P@5')
- 'better than every comparable system that doesn't pay for a language-
  model call on every retrieval' (the load-bearing honest framing,
  without naming the competitors mid-hook)
- ends with '[Receipts on the evals →]' linking down

**'## Benchmarks' renamed '## Receipts on the evals'** with a glossary
at the top defining R@5, P@5, and 'no LLM in the loop' in one line each.
Then the full tables: LongMemEval cross-system (with the metric-mismatch
flag for Mastra/Supermemory), in-house BrainBench scorecard, source-swamp
resistance, and prompt compression. The competitor names + metrics stay
here where readers who want the receipts can find them, with the
glossary so the acronyms don't tax cold readers.

Net: lead reads as 'here's what it does and the proof' instead of 'here
are the benchmark numbers, figure out what they mean.' Comparison facts
unchanged.

Privacy + verify gate + build-llms test all pass.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(README): name LongMemEval explicitly + first-person voice in lead

Two specific edits from user feedback:

1. 'the standard public benchmark for AI memory systems' → 'LongMemEval'
   (linked to the HuggingFace dataset). The benchmark has a name; use it.

2. 'Built by the President and CEO of Y Combinator to run his own AI
   agents' (passive third-person) → 'I'm the President and CEO of Y
   Combinator, and I use this 16 hours a day' (active first-person).
   Carried the voice change through the rest of the README — the
   downstream 'Garry's personal agent' line and the Origin section's
   'Garry Tan needed... he'd ever drafted... so he built one' all flip
   to first person ('my personal agent', 'I needed', 'I'd ever drafted',
   'so I built one'). The README is now consistently first-person from
   the author's voice instead of a hagiographic third-person framing.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>

* docs(README): add Multi-player and company brains section

Three deployment patterns documented:

1. Single GBrain server + thin MCP clients (recommended). Tailscale
   private networking, OAuth scope, source-scoped clients, exhaustive
   what-clients-can/cannot-do lists.
2. Local PGLite + GStack for per-worktree code search.
3. Federated repos (advanced) — multiple servers indexing the same
   brain repo.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs(README): tighten install path + add tech-orientation block + visceral query example

Self-eval as a cold reader surfaced four gaps blocking a 10/10 first read:

1. Lead never says WHAT it is technically — CLI? service? cloud? local?
   Added a "What it is, technically" block right after the hook: open-source
   MIT, Bun CLI + MCP server, local-first, data stays on disk, MCP-native.
2. Install path optimized for committed users not evaluators. The old
   "recommended" path (deploy OpenClaw on Render, 8GB RAM) blocked anyone
   trying gbrain for the first time. Reordered into 3 paths by commitment:
   60-second standalone CLI first, MCP for Claude Code / Cursor second,
   full agentic install third.
3. No example output showing what success looks like. Added a real sample
   `gbrain query` invocation with the hybrid-search result format so a
   reader can feel the experience before they install.
4. Privacy / data-locality unaddressed in lead. Now stated up front:
   embedding calls only hit external APIs if you configure them.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.7 <noreply@anthropic.com>
 2026-05-18 12:53:01 -07:00
Garry Tan
dd1cc121d8 v0.35.3.1 feat(eval): temporal-aware contradiction probe + verdict enum (#1052) 
* rfc: temporal axis for contradiction probe

Field report on residual HIGH findings from gbrain eval suspected-contradictions
and proposal for a 4-phase fix (Phase 1 = judge prompt + verdict enum is the
recommended starting point).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(eval): pass effective_date to judge prompt; bump PROMPT_VERSION

Lane A1 of the temporal-contradiction-probe wave. Threads page-level
effective_date through the search projection into the contradiction judge so
the LLM can reason about supersession instead of treating every dated pair as
a contradiction.

Changes:
- SearchResult interface adds optional effective_date + effective_date_source
  fields; rowToSearchResult populates them from the row data with date-only
  YYYY-MM-DD normalization (handles both postgres.js Date and PGLite string).
- 8 SELECT projection sites (3 in postgres-engine, 5 in pglite-engine) now
  carry p.effective_date + p.effective_date_source through their inner CTEs
  and outer SELECTs so search results expose the field on both engines.
- PairMember (eval-contradictions/types.ts) gets the two fields as required
  (string | null) so the type forces every constructor to think about temporal
  anchoring. Runner's searchResultToMember + takeToMember handle the
  normalization; takes inherit the chunk's page-level date.
- buildJudgePrompt emits `Statement A (from: YYYY-MM-DD)` when effective_date
  is non-null, else `(date unknown)`. Prompt instructions explain the tag so
  the model knows what to do with it.
- PROMPT_VERSION bumps '1' → '2'. Cache-key tuple shape unchanged; old rows
  miss naturally on first run against the new prompt.

Test fixtures in 5 files updated to include the new required fields. All 205
eval-contradictions unit tests + 101 search-related tests pass. Typecheck
clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(eval): replace contradicts:boolean with verdict:enum (6 members)

Lane A2 of the temporal-contradiction-probe wave. Expands the judge's
classification vocabulary from a binary contradicts:bool to a six-member
verdict enum so the probe can distinguish "this changed" from "this is wrong".

Verdict taxonomy:
  no_contradiction       — drop from findings
  contradiction          — genuine conflict at same point in time
  temporal_supersession  — newer claim updates/replaces older; not an error
  temporal_regression    — metric/status went backwards over time (signal)
  temporal_evolution     — legitimate change, neither supersession nor regression
  negation_artifact      — judge misread an explicit negation

Changes:
- types.ts: Verdict union (6 members); Severity gains 'info'; ResolutionKind
  extended with temporal_supersede, flag_for_review, log_timeline_change;
  JudgeVerdict.contradicts → verdict; ContradictionFinding now carries verdict;
  ProbeReport adds queries_with_any_finding + verdict_breakdown (additive).
- judge.ts: parseResolutionKind + parseVerdict guards; normalizeVerdict reads
  the new field and applies the C1 confidence floor only to verdict='contradiction'
  (the new verdicts are informational classifications, no floor). Prompt rubric
  rewritten to ask for verdict + extended severity scale.
- severity-classify.ts: 'info' joins the rank with value 0; defaultSeverityForVerdict
  maps each verdict to its baseline severity (D7 — supersession=info, regression=high,
  etc.). parseSeverity gains a fallback param so consumers can override 'low' default.
- auto-supersession.ts: classifyResolution + renderResolutionCommand handle the
  three new resolution kinds. Probe still NEVER auto-mutates — the new kinds
  render paste-ready commands or informational lines.
- cache.ts: isJudgeVerdict shape check matches the new verdict field; old v1
  rows fail the guard and treat as misses.
- runner.ts: emit predicate at cache-hit and judge-success branches changes
  from `verdict.contradicts` to `verdict.verdict !== 'no_contradiction'`.
  Without this, the new verdicts vanish from the report. Added per-verdict
  tally + queriesWithAnyFinding alongside the strict queriesWithContradiction.
- trends.ts: latest run verdict breakdown surfaces in the trend chart.

Test fixtures updated across 8 test files. All 210 eval-contradictions unit
tests pass. Typecheck clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(eval): relax date-filter rule 3 when both sides dated

Lane B of the temporal-contradiction-probe wave. The v1 date pre-filter
skipped pairs whose chunk-text-extracted dates differed by >30 days as a
cost-saving heuristic. That heuristic silently killed exactly the cases the
new verdict taxonomy exists to surface — role transitions across years
(e.g. a 2017 historical record vs. a 2025 current state), MRR claims years
apart, status changes recorded over time.

Lane A1+A2 made temporal supersession explicit and cheap to classify. The
filter no longer needs to skip these pairs; the judge can label them.

Changes:
- date-filter.ts: shouldSkipForDateMismatch accepts optional effectiveDateA
  and effectiveDateB. When BOTH are non-null, returns skip=false with the new
  'both_have_effective_date' reason — the judge will see the dates via the
  (from: YYYY-MM-DD) prompt tag from Lane A1. Other rules (same-paragraph
  dual-date override, missing-date fallback) preserved verbatim and still
  run first.
- runner.ts: threads pair.{a,b}.effective_date into the date-filter call.
  Pairs that previously vanished into the skip bucket now reach the judge.

Tests (R1 IRON RULE regression suite, 6 new cases):
- both sides effective_date → not skipped
- both sides effective_date overrides >30d chunk-text rule
- rule 1 (same-paragraph dual-date) still wins over effective_date relaxation
- rule 2 (missing chunk dates) still applies when effective_date partially present
- undefined effective_dates fall through to v1 behavior (back-compat)
- empty-string effective_date treated as missing (only real dates enable the relaxation)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(cli): cost-estimate prompt + --budget-usd + Haiku routing

Lane C of the temporal-contradiction-probe wave. Three layers of cost
guardrail, all stacked:

(a) cost-estimate prompt at probe-run-time. Before the runner spends any
    tokens after a PROMPT_VERSION change, eval-suspected-contradictions
    reads the most recent persisted prompt_version from
    eval_contradictions_runs and compares. When they differ:
      - TTY: prints an upper-bound estimate + Ctrl-C window (default 10s,
        override via GBRAIN_PROBE_PROMPT_GRACE_SECONDS).
      - non-TTY: prints the estimate + auto-proceeds (autopilot path).
      - --yes override or GBRAIN_NO_PROBE_PROMPT=1: skip entirely.
    Mirrors the v0.32.7 runPostUpgradeReembedPrompt pattern.

(b) --budget-usd N hard cap (pre-existing; PreFlightBudgetError surfaces
    when the estimate alone exceeds the cap, and CostTracker halts the
    run mid-flight when cumulative cost exceeds it). Documented in the
    help text alongside (a).

(c) Judge model now routes through resolveModel() with configKey
    'models.eval.contradictions_judge', tier 'utility' (Haiku-class
    default), and env var GBRAIN_CONTRADICTIONS_JUDGE_MODEL. The legacy
    --judge CLI flag still wins as the highest-precedence override.
    Doctor's model touchpoint registry (src/commands/models.ts:50) carries
    the new key so `gbrain models` and `gbrain models doctor` surface it.

Also in this lane:
- CLI: --severity accepts 'info' (the new Severity member from Lane A2).
- CLI: --severity output shows [verdict] tag alongside slug pairs so
  operators distinguish genuine contradictions from temporal classifications.
- Human summary: prints the new queries_with_any_finding metric and the
  per-verdict breakdown table.
- Help text: explains the cost-prompt + budget-cap + model-routing
  interactions in one paragraph.

New tests (9 cases on the cost-prompt helper):
- --yes override skips
- GBRAIN_NO_PROBE_PROMPT=1 skips
- prompt_version unchanged → skips
- non-TTY auto-proceeds with stderr note
- TTY proceeds after grace
- TTY aborts on Ctrl-C
- fresh brain (no prior runs) fires the prompt
- GBRAIN_PROBE_PROMPT_GRACE_SECONDS override honored
- estimate banner contains query count + judge model + dollar amount

All 225 eval-contradictions tests + 25 model-config tests pass. Typecheck clean.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(eval): R4/R5/R6 IRON-RULE regressions for the verdict-enum wave

Lane D of the temporal-contradiction-probe wave. The Lanes A1/A2/B/C lanes
landed the behavior; this lane pins the regressions that protect the wave
against future drift.

R4 (runner emit predicate): five new tests, one per non-no_contradiction
verdict, prove the runner.ts emit rule surfaces each one as a finding with
the correct verdict tag, and that:
  - queries_with_contradiction (Wilson-CI denominator) ONLY counts verdict
    ='contradiction' — the strict metric is preserved
  - queries_with_any_finding counts every non-no_contradiction verdict
  - verdict_breakdown tallies correctly
Plus one negative case: verdict='no_contradiction' produces zero findings.
Without R4, a future runner refactor could collapse the new verdicts back
to /dev/null and the report would silently shrink.

R5 (cache key shape): direct shape assertion on buildCacheKey output. The
key tuple is exactly 5 fields (chunk_a_hash, chunk_b_hash, model_id,
prompt_version, truncation_policy). Adding a 6th field would silently break
every operator's brain (no migration path).

R6 (contradiction severity unchanged): four tests on normalizeVerdict pin
the legacy semantics — judge-supplied severity wins (whether 'high' or
'low'), and on garbage severity input the fallback is 'medium' (per
defaultSeverityForVerdict('contradiction')) NOT 'low'. The contradiction
verdict's severity must never default to 'low', which would silently mask
genuine conflicts as cosmetic naming issues. The temporal_regression case
is included for parity (garbage → 'high' since regressions are real
investor red flags).

236 eval-contradictions tests pass (211 + 6 R4 + 1 R5 + 4 R6 + 9 cost-prompt
from Lane C).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* feat(ci): privacy lint for docs/proposals/*.md

Captures the residual TODO from the temporal-contradiction-probe wave's
plan: prevent the bug class where an RFC lands in docs/proposals/ with
PII that should never appear in a public technical artifact. The
original RFC had to be scrubbed at force-push time (Step 0); this lint
catches the same patterns at CI time so the next one can't slip through.

Sibling to scripts/check-privacy.sh:
- check-privacy.sh: bans the literal "Wintermute" repo-wide.
- check-proposal-pii.sh: focuses on docs/proposals/*.md and the OTHER
  PII classes — personal-relationship vocabulary, private repo refs.

Design contract: the denylist names PATTERNS, not real people. Naming
specific real names (deceased relatives, therapist first names,
dealflow contacts) inside this script would leak PII into the repo
just by appearing here. The structural patterns below catch the
SURROUNDING vocabulary that always accompanies such content in
personal RFC prose. Trade-off: a future RFC that names a real person
without any contextual markers won't be caught — accepted as residual
risk handled by human review.

Patterns flagged in docs/proposals/*.md:
- garrytan/brain (private repo reference)
- trial separation, permanent separation
- couples session, couples therapist
- divorce attorney(s)
- grandmother's funeral, aunt's funeral
- wintermute (also caught by check-privacy.sh; listed here for
  proposal-scoped clarity)

Bare common words (separation, funeral) are NOT banned — only the
combined personal-context phrases. "Separation of concerns" and other
software vocabulary survives.

Wired into:
- `bun run verify` (gates every push)
- `bun run check:all`
- `bun run check:proposal-pii` (standalone)

Tests: 15 cases in test/scripts/check-proposal-pii.test.ts.
- Each pattern flagged when present, plus exit-code + stderr signal.
- Two negative cases (separation-of-concerns, funeral metaphor) prove
  the lint doesn't false-positive on legitimate software prose.
- No-proposals-dir → exit 0 (not a failure).
- Multi-hit case proves all patterns surface together with a summary
  count.
- The two test fixtures that name "Wintermute" / "WINTERMUTE" as
  sentinel literals are allowlisted in check-test-real-names.sh per
  the same meta-rule-enforcement exception as check-privacy.sh itself.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(privacy): allowlist new privacy-guard files in check-privacy.sh

check-privacy.sh bans the literal Wintermute repo-wide. The two new files
from the v0.34 privacy lint (scripts/check-proposal-pii.sh and its test)
necessarily name the token to do their job. Same meta-rule-enforcement
exception as scripts/check-privacy.sh itself, scripts/check-test-real-names.sh,
test/recency-decay.test.ts, and the existing entries — describing what
the rule forbids requires naming it.

Without this allowlist, `bun run verify` fails on check:privacy.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore: bump version and changelog (v0.35.1.0)

Temporal-contradiction-probe wave — Phase 1 of the RFC at
docs/proposals/temporal-contradiction-probe.md.

Headline: the contradiction probe now classifies pairs into a 6-member
verdict enum (no_contradiction, contradiction, temporal_supersession,
temporal_regression, temporal_evolution, negation_artifact) and sees the
page-level effective_date for each chunk via a (from: YYYY-MM-DD) tag in
the prompt. The pre-judge date filter no longer skips dated wide-gap pairs,
so the role-transition class (e.g. a 2017 historical record vs. a 2025
current state) reaches the judge and gets classified as
temporal_supersession instead of vanishing into the skip bucket.

PROMPT_VERSION bumped 1 → 2 (cache fully invalidated). Three-layer cost
guardrail: TTY-only cost-estimate prompt with Ctrl-C window, --budget-usd
hard cap, Haiku-tier routing via new models.eval.contradictions_judge
config key.

Also adds a CI privacy lint (scripts/check-proposal-pii.sh) wired into
bun run verify that catches PII patterns in docs/proposals/*.md so future
RFCs can't ship with personal-context vocabulary the way this wave's
source RFC did at draft time.

Phases 2-4 deferred to follow-up RFCs per the plan.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: garrytan-agents <garrytan-agents@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-17 08:32:03 -07:00
Garry Tan
bd2fe8a1fa v0.32.5 feat: gbrain-context OpenClaw context engine — deterministic temporal/spatial injection (#880) 
* feat: gbrain-context OpenClaw context engine — deterministic temporal/spatial injection

Adds a context engine plugin that runs on every assemble() call to inject
structured live context into the system prompt:

- Garry's current local time (computed from heartbeat-state.json timezone)
- Current location (city + timezone from heartbeat or flight data)
- Home time when traveling (e.g. 'Mon 7:58 AM PT')
- Active travel status
- Quiet hours detection
- Airport→timezone mapping for 30+ airports

This kills the 'time warp' bug class where compacted sessions lose track
of time/location. The engine delegates compaction to the legacy runtime
and only owns systemPromptAddition injection. Zero LLM calls, <5ms.

Files:
- src/core/context-engine.ts — engine implementation (SDK-free, testable)
- src/openclaw-context-engine.ts — plugin entry point (requires SDK)
- test/context-engine.test.ts — 9 tests, all passing

Enable: plugins.slots.contextEngine = 'gbrain-context'

* feat: add activity injection — calendar events + open tasks in context block

Reads memory/calendar-cache.json and ops/tasks.md to inject:
- **Right now:** current meeting (with attendees) from calendar
- **Coming up:** next 3 events within 4-hour window
- **Open tasks:** unchecked items from Today section
- Stale calendar warning when cache is >6 hours old

Skips all-day events and generic markers (Home, OOO, Out of Office).
Caps upcoming events at 3 and tasks at 5 to keep prompt lean.

15 tests passing (was 9).

* v0.32.5 feat: gbrain-context OpenClaw context engine — deterministic temporal/spatial injection

Ships PR #873 by @garrytan-agents (two underlying commits preserved):
  - f1dbe6ea — core engine (heartbeat + flights + airport→tz + quiet hours)
  - 14e85873 — activity injection (calendar events + open tasks + stale-cache warning)

Kills the "time warp" bug class: when sessions compact, the LLM loses track
of current time, location, and active threads. This engine owns the
`systemPromptAddition` slot and reinjects live state on every `assemble()`
call. Zero LLM calls, <5ms overhead, deterministic.

Typecheck cleanup folded in:
  - `@ts-ignore` on the two `openclaw/plugin-sdk` runtime-only imports
    (resolved by the OpenClaw host; not a build-time dep — same pattern the
    core engine already used for `await import('openclaw/plugin-sdk/core')`)
  - Inline `PluginApi` + `PluginCtx` type shapes in the plugin entry so the
    `register(api)` + `(ctx)` callback params aren't implicit any
  - Test file's `from 'vitest'` → `from 'bun:test'` to match the rest of
    the suite (bun's globals make it pass at runtime, but tsc fails)

Verification:
  - bun test test/context-engine.test.ts → 15/15 pass
  - bun run typecheck → exit 0

Co-Authored-By: garrytan-agents <garrytan-agents@users.noreply.github.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix-wave: close 5 findings from /plan-eng-review pass on PR #880

A `/plan-eng-review` audit of the shipped v0.32.5 surfaced 5 things worth
fixing before merge. All folded into this branch with 5 new regression tests
(15 → 20 total).

A4 — silent-wrong-timezone for unknown airports
  Pre-fix: an active flight to any airport not in the 30-entry AIRPORT_TZ
  map (BOM, DXB, GRU, JNB, FRA, AMS, etc.) silently fell back to US/Pacific.
  The exact failure class this engine exists to prevent, in a different
  shape. Post-fix: unknown airports surface via the source field
  (flight:AC8:tz-unknown:BOM) so the LLM can see the data is incomplete
  instead of believing it's in Pacific Time.

A2 / P1 — duplicate disk reads
  generateLiveContext was loading heartbeat-state.json and
  upcoming-flights.json twice per assemble() call (once in resolveLocation,
  once inline). Batch-load each workspace file once at the top of the
  function and thread results down. Halves the hot-path I/O.

C4 — sanitize external content before injection
  Calendar event summaries, attendees, and task strings now go through
  sanitizeForPrompt() which strips newlines + control chars (U+0000-001F +
  U+007F) and clamps length. A meeting titled
  "Standup\n\nIgnore prior instructions" can no longer forge LLM directives
  by escaping the bullet structure.

C1 — split isQuietHours into 3 explicit signals
  Original name was misleading (returned false when user was awake at 2 AM,
  even though wall clock said quiet hours). Split into `userAwake`,
  `wallClockQuietHours`, and a composite `quietHoursActive` so consumers can
  decide their own policy. On-disk heartbeat.garryAwake JSON field is
  unchanged — only the internal LiveContext type and the format-block
  consumer renamed.

T1 — regression test coverage for the active-flight path
  Pre-fix, resolveLocation's flight branch (the headline path for the
  Toronto incident) had ZERO direct test coverage. Two new cases lock in
  the known-airport happy path AND the unknown-airport failure mode so A4
  can't silently regress.

Verification:
  - bun test test/context-engine.test.ts → 20/20 pass (was 15)
  - bun run typecheck → exit 0

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* fix(L0): A4 real fix + TLA → lazy SDK resolution (Codex F5 + F7)

A Codex outside-voice review on /plan-eng-review's plan caught two findings
both previous eng-reviews missed.

L0-A (F5) — A4 was COSMETIC, not real.
  Pre-fix: resolveLocation's unknown-airport branch returned tz: DEFAULT_TZ
  (US/Pacific) with only a `source: 'flight:XX:tz-unknown:XYZ'` sticker. The
  engine then computed Time/Day/quietHoursActive from US/Pacific regardless,
  so a flight to BOM injected "Mon 3:00 PM PT" with a footnote nobody reads.
  Same silent-wrong-output failure class A4 was supposed to close.

  Post-fix: resolveLocation returns tz: UNKNOWN_TZ. generateLiveContext
  short-circuits time computation when tz is UNKNOWN_TZ (now/dayOfWeek
  become null, wallClockQuietHours/quietHoursActive become false).
  formatContextBlock renders an explicit Timezone-unavailable warning in
  place of Time:/Day:. The LLM sees the gap, not a guess.

L0-B (F7) — Top-level `await import` is a hard module-load constraint.
  Any OpenClaw deployment in a non-TLA runtime (older Node, CJS bridges,
  certain transpilers, some test shims) fails BEFORE the plugin registers.
  The try/catch inside doesn't help — module load can't be caught by the
  consumer.

  Post-fix: SDK resolution moved to an `ensureSdkLoaded()` async helper
  called from assemble() and compact() on first invocation. Module loads
  cleanly in every runtime; the fallback path actually catches.

Tests:
  - The cosmetic "tz-unknown sticker" assertion is replaced with the
    behavioral assertion: no US/Pacific Time, no Day field, explicit
    Timezone-unavailable warning present.
  - New L0-B contract test asserts engine creation does NOT trigger SDK
    load and the first compact() call exercises the lazy path.

Verification:
  - bun test test/context-engine.test.ts → 21/21 pass (20 + L0-B contract)
  - bun run typecheck → exit 0

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(L1): scrub real names from test fixtures + CI guard (CLAUDE.md privacy rule)

The /plan-eng-review pass flagged pre-existing real-name leaks in PR #873's
test fixtures. CLAUDE.md's privacy rule is unambiguous: "Never reference real
people, companies, funds, or private agent names in any public-facing
artifact." Tests are checked-in code, distributed with every release, and
indexed by GitHub search.

Fixture scrub (test/context-engine.test.ts, 5 substitutions):
  '1:1 with Diana' → '1:1 with @alice-example'
  'diana@ycombinator.com' → 'alice@example.com'
  'DM Technium re: Hermes PR' → 'DM @charlie-example re: agent-fork PR'
  'Post open source manifesto — from YC Labs' → '... from a-team'
  '~~Reply to Bob McGrew~~ — DONE' → '~~Reply to bob-example~~ — DONE'
Plus matching assertion updates.

Adjacent scrub: test/link-extraction.test.ts line 523 fixture entry
'people/diana-hu' → 'people/alice-example' (single occurrence, never
referenced elsewhere in the test).

New CI guard (scripts/check-test-real-names.sh, ~120 lines):
  Designed per Codex F4 review: drop the broad corporate-email regex
  (@openai|google|stripe...) because legitimate billing/auth fixtures use
  those domains. Replace with two targeted lists:
    - BANNED_NAMES: exact-string list of known real identifiers
      (Diana, Wintermute, Hermes, Technium, McGrew, YC Labs)
    - BANNED_EMAILS: specific addresses (currently just diana@ycombinator.com)
  Plus ALLOWLIST of exact `file:string` pairs that are intentional and
  pre-existing (the user's own email; structural tests that ASSERT a banned
  name is absent and therefore MUST reference it literally).

  Scope: test/**/*.test.ts only. Historical CHANGELOG entries, doc examples,
  and skill READMEs each have their own scrub status and are out of scope
  for this guard.

Wire-in:
  - New `bun run check:test-names` npm script
  - Added to `bun run verify` chain (pre-push gate)
  - Added to `bun run check:all` chain (local-only superset)

Allowlist documents the structural references the guard correctly identifies
but cannot meaningfully strip:
  - test/integrations.test.ts (regex pattern in personal-info filter test)
  - test/recency-decay.test.ts (regression-prevention assertions)
  - test/serve-stdio-lifecycle.test.ts (pre-existing comment)
  - test/extract.test.ts (pre-existing markdown-link fixture)

These flagged-but-not-scrubbed entries belong to a broader repo-wide
privacy-scrub pass (deferred TODO).

Verification:
  - bun run check:test-names → exit 0 (no new banned strings)
  - bun test test/context-engine.test.ts → 21/21 pass
  - bun test test/link-extraction.test.ts → 98/98 pass

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(L2): plugin-shape e2e + compact fallback + selector map + race-condition JSDoc

The unit suite at test/context-engine.test.ts exercised
createGBrainContextEngine directly — that's the ENGINE, not the PLUGIN. Until
this commit, nothing tested the actual OpenClaw plugin discovery + registration
path. Codex outside-voice F1 flagged the gap: "we ship a plugin we don't test
as a plugin."

Layer 2 closures:

T-NEW1 (plugin-shape e2e, test/e2e/openclaw-context-engine-plugin.test.ts, 3 tests):
  - Default export has the expected plugin-entry shape (id, name, description, register)
  - register() wires registerContextEngine with ENGINE_ID and a factory
  - Factory returns a working ContextEngine that injects Live Context and
    threads through the mocked memory-addition SDK call

  Implementation note: dropped the unused `definePluginEntry` import from
  src/openclaw-context-engine.ts. The wrapper was a type-tag with no behavior
  — OpenClaw's loader inspects the default export's shape, not the wrapping.
  Removing it eliminated a brittle build-time SDK import that blocked
  mock.module() interception (Codex F1 was right). Module now loads cleanly
  in any runtime.

T-NEW4 (compact() fallback test, test/context-engine.test.ts):
  - Pins the no-runtime fallback shape so a refactor that drops the fallback
    or returns a different shape gets caught.
  - Codex F9 noted that without a real SDK boundary, a spy-on-delegate test
    is busywork. This commit keeps just the fallback assertion (no spy, no
    __internal export-for-tests hatch).

T-NEW6 (heartbeat-write concurrency contract, src/core/context-engine.ts):
  - JSDoc on loadJsonFile documenting that producers MUST use atomic-rename
    writes (write-to-tmp + rename) to avoid partial-read races. The engine
    silent-degrades to defaults on parse failure; the contract makes the
    expectation explicit instead of buried in behavior.

T-NEW5 (e2e selector map, scripts/e2e-test-map.ts):
  - Added entries mapping src/core/context-engine.ts and
    src/openclaw-context-engine.ts to the new plugin e2e file. ci:local:diff
    now narrows correctly for engine changes.

Verification:
  - bun test test/context-engine.test.ts → 22/22 pass (21 + T-NEW4)
  - bun test test/e2e/openclaw-context-engine-plugin.test.ts → 3/3 pass
  - bun run typecheck → exit 0

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* chore(L3): ENGINE_VERSION → ENGINE_API_VERSION semantic + tasks.md size cap

C-NEW1 — Engine version constant semantic.
  Pre-fix: `ENGINE_VERSION = '0.1.0'` looked like it should track
  package.json. It doesn't — it's the engine's CONTRACT version, bumped
  when the ContextEngine interface shape changes. Rename to
  ENGINE_API_VERSION makes that explicit. ENGINE_VERSION kept as a
  deprecated alias so existing v0.32.5 callers don't break.

C-prior C2 — tasks.md size cap.
  resolveTodayTasks() now refuses to read a tasks file >1MB. Defends
  against a runaway file (clipboard-paste accident, log capture, etc)
  blocking every assemble() call with a multi-megabyte sync read. The
  size check uses statSync — same try/catch already handles
  missing-file via readFileSync throwing.

Verification:
  - bun test test/context-engine.test.ts → 23/23 pass (22 + size-cap test)
  - bun test test/e2e/openclaw-context-engine-plugin.test.ts → 3/3 pass
  - bun run typecheck → exit 0

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* docs: CHANGELOG + TODOS for the Codex recalibration wave; allowlist sibling guard

CHANGELOG.md — extend v0.32.5 entry with a "Codex outside-voice
recalibration" subsection covering L0-A (A4 real fix), L0-B (TLA → lazy),
the privacy guard redesign, the new plugin-shape e2e, and the deferred
v0.32.6 items. Credits gpt-5-codex as the driver.

TODOS.md — append "v0.32.6 follow-ups from PR #880" section with 13
deferred items:
  - Clock-injection seam (prerequisite for perf + snapshot tests)
  - T-NEW2 perf budget (with Codex F2 math-bug note)
  - T-NEW3 full-block snapshot test
  - C-NEW2 exports map entry (per Codex F8 — premature public API)
  - A3 .ts-extension resolution coupling
  - A5 typed openclaw/plugin-sdk ambient module shim
  - C-prior C5 loadJsonFile parse-error warn
  - C-prior C3 fractional-hour timezone offset
  - DST-boundary test
  - Multibyte sanitizer test
  - Dynamic airport-tz lookup (replace 30-entry static map)
  - DOC1 docs/openclaw-context-engine.md workspace contract
  - DOC2 CLAUDE.md "Key files" annotations
  - Repo-wide privacy scrub (24+ non-test matches)

scripts/check-privacy.sh — allowlist sibling guard
scripts/check-test-real-names.sh, which literally contains 'Wintermute' in
its BANNED_NAMES list (same meta-rule-enforcement exception as
check-privacy.sh's self-reference).

Verification:
  bun run verify → exit 0 (full chain green: check:privacy + check:test-names
  + check:jsonb + check:progress + check:test-isolation + check:wasm +
  check:admin-build + check:admin-scope-drift + check:cli-exec + typecheck)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

* test(L4): real openclaw-loads-the-plugin e2e — closes Codex F1 properly

Until this commit, the gbrain-context plugin had two test paths:
  - test/context-engine.test.ts (23 unit tests against createGBrainContextEngine)
  - test/e2e/openclaw-context-engine-plugin.test.ts (3 e2e tests with mocked SDK)

Both call our engine directly or shim the OpenClaw SDK. Codex outside-voice
F1 (cited at v0.32.5 ship) flagged that nothing in the repo proves OpenClaw's
actual plugin loader walks our entry file, calls register(api) against its
real api object, and accepts the registration. The reviewer was right —
shipping a plugin without an "OpenClaw actually loads it" test is a
credibility hit on a feature whose entire purpose is to integrate with
OpenClaw.

L4 — test/e2e/openclaw-plugin-load-real.test.ts (6 tests, Tier 2):

  beforeAll:
    - Detects `openclaw` CLI; skips suite if missing
    - bun build src/openclaw-context-engine.ts → JS bundle (same packaging
      shape the release ships)
    - Writes minimal package.json + openclaw.plugin.json from templates
    - openclaw plugins install --link --dangerously-force-unsafe-install
      against an isolated --profile dir (won't touch user's openclaw state)

  Tests:
    1. status=loaded, imported=true, activated=true
    2. Default-export id/name/description metadata round-trips through
       openclaw's plugin loader unchanged
    3. register(api) produced zero error-level diagnostics (only the
       expected trust warning for --link installs)
    4. plugins.slots.contextEngine binding to "gbrain-context" passes
       openclaw config validate
    5. openclaw plugins doctor surfaces zero errors for our plugin id
    6. Public-SDK round-trip: imports registerContextEngine from
       openclaw/plugin-sdk (resolved via realpathSync on the openclaw
       binary's symlink so it works for Homebrew, npm -g, nvm, asdf,
       volta installs uniformly), registers our factory, then exercises
       assemble() and asserts the Live Context block appears

  afterAll:
    - Uninstalls the plugin (best-effort) + rm -rf the isolated profile
      dir + the tempdir fixture

Fixture: test/fixtures/openclaw-plugin-real/ holds the manifest templates
(package.json.template + openclaw.plugin.json.template). The test writes
fresh copies into a per-run tempdir so the fixture itself stays read-only.

Selector map: scripts/e2e-test-map.ts now points BOTH source files
(src/core/context-engine.ts, src/openclaw-context-engine.ts) at BOTH the
mocked-SDK plugin-shape e2e AND this real-loader e2e. ci:local:diff fires
both on either change.

Verification:
  - bun test test/e2e/openclaw-plugin-load-real.test.ts → 6/6 pass
  - bun test test/context-engine.test.ts test/e2e/openclaw-context-engine-plugin.test.ts
    test/e2e/openclaw-plugin-load-real.test.ts → 32/32 pass total
  - bun run typecheck → exit 0
  - bun run verify → exit 0 (full chain green)

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>

---------

Co-authored-by: garrytan-agents <garrytan-agents@users.noreply.github.com>
Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
 2026-05-11 21:49:57 -07:00